Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid svg clock faces #2072

Closed
ghost opened this issue Jul 5, 2020 · 4 comments
Closed

Invalid svg clock faces #2072

ghost opened this issue Jul 5, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 5, 2020 •
edited by ghost
Loading

All new 2.12.0 verison svg files in clock faces folder are invalid svg format, use the old ones.
I think replacing unsecure links with https ones make format invalid.

https://forum.magicmirror.builders/topic/13190/no-numbers-in-analog-watch-face
@MichMich
Copy link
Collaborator

MichMich commented Jul 5, 2020

Does it prevent them from loading in electron?
Feel free to send a PR. Although I think this is caused by prettier. So sending a PR might fail on Travis.

rejas added a commit to rejas/MagicMirror that referenced this issue Jul 5, 2020
@rejas
Fix incorrect namespace links in svg clockfaces
9219329 
Fixes MagicMirrorOrg#2072
@rejas rejas mentioned this issue Jul 5, 2020
Merged
@MichMich
Copy link
Collaborator

MichMich commented Jul 5, 2020

Fix merged into develop thanks to @rejas.

@MichMich MichMich closed this as completed Jul 5, 2020
@ghost
Copy link
Author

ghost commented Jul 20, 2020 •
edited by ghost
Loading

face-006.svg still not valid format

@MichMich MichMich reopened this Jul 20, 2020
@rejas rejas mentioned this issue Jul 20, 2020
Merged
@MichMich
Copy link
Collaborator

Should be fixed now. Thanks @rejas!

@MichMich MichMich mentioned this issue Jul 20, 2020
Closed
@khassel khassel mentioned this issue Aug 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichMich