-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDNA encoding of hostname #95
Comments
You could skip encoding by sending |
Yes, but the |
Yes, there's a fast test. I'll look into this. |
Fixed in master. Will be in 0.9.0 release (soon) |
Please try uvloop v0.9.0. |
PYTHONASYNCIODEBUG
in env?: I don't knowCommit 1d5ae0b introduces IDNA encoding. While this is a good solution for FQDN hostnames, this is really a performance killer when sending a lot of small packets using lots of IP address (use case in boramalper/magnetico#92). On my CPU, the IDNA encoding is taking ~5% of the whole program execution, and more than 75% of the
sendto
method call.The main issue here is that the
sendto
call is done with address given with the call todatagram_received
, souvloop
should be already aware that the hostname is an IP address.I guess that
datagram_received
cannot return an encoded hostname, but the idea is here.The text was updated successfully, but these errors were encountered: