some improvements #20
Conversation
|
|
||
| --- | ||
|
|
||
| Alternative: |
There was a problem hiding this comment.
Let's combine this alternative with my OG instructions, they are quite similar
There was a problem hiding this comment.
Yes!
Could you please combine them?
I don't know how you'd like your part integrated with mine
|
|
||
| [Alternative](https://code.visualstudio.com/api/get-started/your-first-extension): | ||
|
|
||
| - open `src/extension.ts` |
There was a problem hiding this comment.
I actually didn't know about this! Thx this has improved my workflow <3
| @@ -37,13 +37,13 @@ | |||
| "command": "vscode-manim.previewManimCell", | |||
| "key": "ctrl+' ctrl+e", | |||
| "mac": "cmd+' cmd+e", | |||
| "when": "editorTextFocus" | |||
| "when": "(editorTextFocus || terminalFocus) && editorLangId == 'python'" | |||
There was a problem hiding this comment.
Sure, let's do it. You don't think it is confusing as to "which line is active" in the og python file when the terminal is active?
There was a problem hiding this comment.
well, if a user is using a shortcut when the terminal is active,
the user probably remembers the line, right?
(Otherwise the user wouldn't be lazy to select the line in the editor)
How do you feel about these additions?