Ask user before killing an active scene #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some weird dependencies between startScene() and the ManimShell and avoids recursion.
|
Don't merge this one without having correctly set the base branch ⚠ |
bhoov
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36.
When a user has a scene open and executes the command
Start scene at cursor, currently the active session is closed and the new one spawned. Instead, we now want to ask the user if they really want to close the active scene. They have multiple choices:When the
Kill it (don't ask again)option is chosen, a workspace setting is updated accordingly. The user can go to the settings to re-enable the confirmation. The user is also informed that such a setting exists.