Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect errors on Manim startup #45

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Detect errors on Manim startup #45

merged 1 commit into from
Oct 28, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Oct 28, 2024 •
edited
Loading

Closes #34.

Here we detect if Manim starts up correctly. If not, we open the terminal and show an error notification. To test this feature, search for manimgl in startStopScene.ts and change it to manimgllll such that it will error.

@Splines Splines added the enhancement-archive Don't use this label anymore. label Oct 28, 2024
@Splines Splines requested a review from bhoov October 28, 2024 00:48
@Splines Splines self-assigned this Oct 28, 2024
@Splines Splines removed the enhancement-archive Don't use this label anymore. label Oct 28, 2024
@Splines Splines mentioned this pull request Oct 28, 2024
Merged
@Splines Splines requested a review from VladimirFokow October 28, 2024 03:39
bhoov
bhoov approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@bhoov bhoov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, good fix

@bhoov bhoov merged commit 9d58204 into main Oct 28, 2024
@bhoov bhoov deleted the fix/startup-error-detection branch October 28, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhoov bhoov bhoov approved these changes

@VladimirFokow VladimirFokow Awaiting requested review from VladimirFokow

Assignees

@Splines Splines

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect errors in Manim startup command
2 participants
@Splines @bhoov