-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Log Recording sessions #59
Conversation
|
|
Just to make sure it's not a caching issue, could you try again now with the new changes? I also wonder if this is just a caching issue while developing the extension or also when the extension is deployed and we use it from the marketplace. If this still doesn't work, we have to be more "brute-force" and delete the file on the computer. I mean, we know exactly where the file is living, so we could program the extension such that it deletes that file upon deactivation. But if possible, I'd like to avoid that. |
doesn't work not with dispose();, not with clear()
|
In the next month(s) ahead - maybe me and bhoov can find the correct solution, |
I came up with a new strategy to handle the logging and updated the PR comment accordingly. Ready for a fresh new review. I'm keen to know if this finally works on MacOS as well (it should). |
Everything works! This is really amazing! |
(I've improved some wording) |
Fixes #58. Fixes #60.
In this PR, we pimp up the logging mechanism and introduce the concept of a "Logging session", i.e. users can start a logging session. When ending it, the log file will automatically open. Please make sure the updated steps of the Troubleshooting section work for you with this PR.
When reviewing, please make sure that the following works additionally: