Reset state upon manual terminal closing #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we detect the event of a user manually closing a terminal that hosts the active Manim IPython session. Further behavior is described in the docstrings:
manim-notebook/src/manimShell.ts
Lines 644 to 655 in 8283ad0
Some reset events might be fired multiple times in the end, but it's better to be safe than sorry here. Multiple calls to
resetActiveShell()
from different places of the code is not a problem.While testing this, please try to force-quit the terminal manually in many different situations to make sure that no state is left dangling, e.g. some notifications still showing or subsequent commands not working anymore.