Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the extension.ts docstrings more detailed #73

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Make the extension.ts docstrings more detailed #73

merged 2 commits into from
Oct 31, 2024

Conversation

VladimirFokow
Copy link
Collaborator

@VladimirFokow VladimirFokow commented Oct 31, 2024 •
edited
Loading

Rewrote some comments to understand them better.

@VladimirFokow VladimirFokow changed the title review extension.ts Review of code Oct 31, 2024
@VladimirFokow VladimirFokow requested a review from Splines October 31, 2024 21:00
@Splines Splines changed the title Review of code Make the extension.ts docstrings more detailed Oct 31, 2024
Splines
Splines approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@Splines Splines left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (as always, use Squash and merge)

(I've just changed the PR title to better reflect what is done here. Review code is a bit vague)

@VladimirFokow VladimirFokow merged commit 8179a13 into main Oct 31, 2024
@VladimirFokow VladimirFokow deleted the review/comments branch October 31, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Splines Splines Splines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladimirFokow @Splines