Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notification if no active Manim session when trying to quit #74

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Oct 31, 2024

Fixes #71, i.e. we now show an information message whenever the user tries to quit the scene while no active scene is running.

I've already implemented such a notification beforehand but accidentally removed it in #48 when fixing the exit scene behavior where the exitScene() was rewritten.

Off-topic

The error message notification when clearing the scene while no active session exists, is changed to an information message. An information message is also used for the notification upon quitting (when no active session exists).

@Splines Splines self-assigned this Oct 31, 2024
@VladimirFokow
Copy link
Collaborator

VladimirFokow commented Oct 31, 2024

oh,
I liked the orange warning
(instead of the blue "i" icon which is now in both "clear" and "quit")

Can we make them back to the warning?
(But it's personal preference, so approving)

@Splines
Copy link
Member Author

Splines commented Oct 31, 2024

But you're right, it's more than just an information. I'd consider it a warning, so I changed it to a warning message now.

@Splines Splines merged commit 7381824 into main Oct 31, 2024
@Splines Splines deleted the feature/quit-notification branch October 31, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create user notification error on Quit preview (if nothing is running)
2 participants