Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manta] Dolphin v2 Parachain #392

Merged
merged 3 commits into from
Feb 10, 2022
Merged

[manta] Dolphin v2 Parachain #392

merged 3 commits into from
Feb 10, 2022

Conversation

dziabko
Copy link
Contributor

@dziabko dziabko commented Feb 9, 2022

Description

Added dolphin runtime to manta branch.

closes: #349


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or dolphin) with right title (start with [Manta] or [Dolphin]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If needed, bump version for every crate.
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If we're going to issue a new release, freeze the code one week early(it depends, but usually it's one week), ensure we have enough time for related testing.

@dziabko dziabko force-pushed the dziabko/v2-dolphin-runtime branch from cd380d8 to b070671 Compare February 9, 2022 21:33
@dziabko dziabko changed the title Dolphin v2 Parachain [manta] Dolphin v2 Parachain Feb 9, 2022
@dziabko dziabko self-assigned this Feb 10, 2022
@dziabko dziabko force-pushed the dziabko/v2-dolphin-runtime branch from b070671 to 945943d Compare February 10, 2022 04:49
@dziabko dziabko requested a review from Dengjianping February 10, 2022 15:12
Copy link
Contributor

@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dziabko dziabko force-pushed the dziabko/v2-dolphin-runtime branch from a54aef9 to 945943d Compare February 10, 2022 15:30
@stechu stechu merged commit 5f63e7b into manta Feb 10, 2022
@Dengjianping Dengjianping deleted the dziabko/v2-dolphin-runtime branch February 11, 2022 03:06
dziabko added a commit that referenced this pull request Feb 24, 2022
* Added dolphin v2 parachain and dolphin genesis file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dolphin V2 Runtime
3 participants