Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apollo #55

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Update Apollo #55

merged 2 commits into from
Jan 12, 2023

Conversation

pchmelar
Copy link
Member

📝 Description

  • This PR updates Apollo to 1.0.2

💡 What’s new?

  • Apollo recently released a new version 1.0.2 with a naming issue fix, so pruneGeneratedFiles is no longer needed

😶 What’s missing?

  • Nothing

📚 References

tomas-bat
tomas-bat previously approved these changes Oct 24, 2022
tommassbrand
tommassbrand previously approved these changes Oct 25, 2022
@pchmelar pchmelar changed the title Update Apollo to 1.0.2 WIP: Update Apollo Oct 25, 2022
@pchmelar
Copy link
Member Author

Turns out that 1.0.2 doesn't fix the issue (therefore CI check failed). We have to wait for 1.0.3
apollographql/apollo-ios#2546 (comment)

AdamPenaz
AdamPenaz previously approved these changes Oct 28, 2022
@calvincestari
Copy link

Hi - I wanted to comment on

Turns out that 1.0.2 doesn't fix the issue (therefore CI check failed). We have to wait for 1.0.3
apollographql/apollo-ios#2546 (comment)

I don't think I'm going to manage to get a fix for the pruning bug into 1.0.3. Can you manually manage file cleanup until I can get that out?

@pchmelar
Copy link
Member Author

pchmelar commented Nov 3, 2022

Hi - I wanted to comment on

Turns out that 1.0.2 doesn't fix the issue (therefore CI check failed). We have to wait for 1.0.3
apollographql/apollo-ios#2546 (comment)

I don't think I'm going to manage to get a fix for the pruning bug into 1.0.3. Can you manually manage file cleanup until I can get that out?

Hey, thanks for stopping by 🙂
No worries, this issue doesn't limit us in any way, as we can still use pruneGeneratedFiles until the issue is resolved.

@pchmelar pchmelar dismissed stale reviews from AdamPenaz, tommassbrand, and tomas-bat via f642e1f January 12, 2023 13:04
@pchmelar pchmelar force-pushed the feature/update-apollo branch from f642e1f to d4c3843 Compare January 12, 2023 13:05
@pchmelar pchmelar changed the title WIP: Update Apollo Update Apollo Jan 12, 2023
@pchmelar
Copy link
Member Author

Fixed in 1.0.6 🚀

@pchmelar pchmelar merged commit 208e65d into develop Jan 12, 2023
@pchmelar pchmelar deleted the feature/update-apollo branch January 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants