Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align NumericUpDown style with other controls #3615

Merged

Conversation

michaelmairegger
Copy link
Contributor

@michaelmairegger michaelmairegger commented Jun 24, 2024

This PR aligns the NumericUpDown style to the one of other controls (closes #3614)

Tasks

  • Add to fields line up
  • Validation Style
  • Floating Hint
  • Helper Text
  • Suffix
  • Prefix

Breaking

Currently IncreaseContent and DecreaseContent are ignored since this two values should be the same as in TimePicker, not changable.

Should we use IncreaseContent and DecreaseContent or remove it. I would prefer to remove it and use it predefined as in TimePicker. If we ignore both properties, then we have to remove it from code before merging

old new
image image
image
image
image
image

@michaelmairegger michaelmairegger changed the title [Work in progress] Align NumericUpDown style with other controls Align NumericUpDown style with other controls Jun 24, 2024
@nicolaihenriksen
Copy link
Contributor

Should we use IncreaseContent and DecreaseContent or remove it. I would prefer to remove it and use it predefined as in TimePicker. If we ignore both properties, then we have to remove it from code before merging

First of all, nice work!

Regarding your comment: I believe we should use them. We should default them to the PackIcon values they have currently, but I see no reason not to let someone manipulate them from the outside. For example if they want up/down arrows instead of +/-.

As for your comment about the TimePicker I think it would also make sense there to make the content configurable; thus could be considered a bug or a missing feature.

@michaelmairegger
Copy link
Contributor Author

@nicolaihenriksen Ok, I will change the code that it will respect the user-configurated values for up/down

@michaelmairegger
Copy link
Contributor Author

@nicolaihenriksen Done

@Keboo Keboo modified the milestones: 5.1.0, 5.2.0 Jun 27, 2024
@Keboo Keboo enabled auto-merge (squash) June 27, 2024 06:25
@Keboo Keboo added enhancement release notes Items are likely to be highlighted in the release notes. labels Jun 27, 2024
@Keboo Keboo merged commit 41489ff into MaterialDesignInXAML:master Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement release notes Items are likely to be highlighted in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumericUpDown style does not align with other controls
3 participants