Fix3628 - Slider ToolTip not showing #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttons of the Slider
…insz/MaterialDesignInXamlToolkit into fix3628SliderToolTipOnClick
This allow fixes it when the slider has a background color, or the user clicks on the ticks above/below the track
Keboo
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3628
This is kinda hacky but I couldn't think of another way of solving this.
Since we don't have a "code file" (Slider.cs) for
Sliders, I added an attached property to theSliderAssistcalledFocusParentSliderOnClick.This AP hooks the
PreviewMouseLeftButtonDownEventof theRepeatButtons and focuses the parentSliderwhen the event is fired.All of this should probably be kept internal.
Additionally I added a helper method
TreeHelper.FindParent<T>(DependencyObject child).