Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] [6.6.0] - User can no longer edit account name to be an empty edit string #6389

Merged
merged 1 commit into from
May 15, 2023
Merged

[FIX] [6.6.0] - User can no longer edit account name to be an empty edit string #6389

merged 1 commit into from
May 15, 2023

Conversation

tommasini
Copy link
Contributor

Description
The user could edit the account name to be an empty string.

Proposed Solution
The user no longer can confirm the name of the account if it is an empty string

Screenshots/Recordings
https://recordit.co/aFO2DqsGzk

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner May 15, 2023 10:38
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the base branch from main to release/6.6.0 May 15, 2023 10:39
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.6.0 Issue or pull request that will be included in release 6.6.0 labels May 15, 2023
sethkfman
sethkfman approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 15, 2023
cortisiko
cortisiko approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit f8bd95d into release/6.6.0 May 15, 2023
@cortisiko cortisiko deleted the fix/970-account-name-empty branch May 15, 2023 19:52
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels May 15, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.6.0 Issue or pull request that will be included in release 6.6.0 team-mobile-platform Mobile Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @sethkfman @cortisiko @gauthierpetetin