Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra #sign-off line from review table #250

Closed

Conversation

ChrisKibble
Copy link
Contributor

Since all commands are author only, having one of the three options called out separately doesn't really serve a purpose.

@JasonWHowell
Copy link
Contributor

JasonWHowell commented May 23, 2019

Hi @ChrisKibble

I think this distinction is important, but it doesn't need a separate row in the table since its the same sign off command. Could you please keep the text as a new line in the first table row? Use the </br> tag to indicate a new line to separate the author vs. non-author scenario.

If a contributor who is not the listed author tries to sign off on a public pull request by using the #sign-off comment, a message is written to the pull request indicating that only the author can assign the label.

@ChrisKibble
Copy link
Contributor Author

Hi @JasonWHowell,

Point well received. Since the same is (probably?) true of all of the commands, what do you think about putting the line below the table as a note that if a non-author tries to use the command they'll receive an error? I'm fine either way, but wanted to throw this alternative idea out there before making the change.

Thanks!
Chris

JasonWHowell added a commit to JasonWHowell/Contribute that referenced this pull request May 29, 2019
JasonWHowell added a commit that referenced this pull request May 30, 2019
)

* Removed extra #sign-off line from review table

* Fixes #250

* Update contribute-how-to-pull-requests-apex-automation.md
@KVSSetty KVSSetty mentioned this pull request Jan 4, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants