Condition on USE_STATVFS in src/filemanager/filegui.c desynchronized with one in m4.include/mc-get-fs-info.m4

[wjaguar]

Is there an existing issue for this?

• I have searched the existing issues

Midnight Commander version

GNU Midnight Commander 4.8.27
Built with GLib 2.70.3
Built with S-Lang 2.3.2 with terminfo database
With builtin Editor and Aspell support
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
With ext2fs attributes support
Virtual File Systems:
 cpiofs, tarfs, sfs, extfs, ftpfs, sftpfs, fish, smbfs
Data types:
 char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;

Operating system

Slackware 15

Is this issue reproducible using the latest version of Midnight Commander?

• I confirm the issue is still reproducible with the latest version of Midnight Commander

Current behavior

The conditions in configure script do not match the conditions in the corresponding C code.
Despite the comment in coreutils clearly saying:
"/* Keep this conditional in sync with the similar conditional in
../m4/stat-prog.m4. */"
The failure to follow that advice means, that some setups can fall in the crack, with neither USE_STATVFS nor !USE_STATVFS working.

Expected behavior

The code in filegui.c need be updated to match what is currently in coreutils' stat.c :

/* Keep this conditional in sync with the similar conditional in
   m4.include/mc-get-fs-info.m4  */
#if ((STAT_STATVFS || STAT_STATVFS64)                                       \
     && (HAVE_STRUCT_STATVFS_F_BASETYPE || HAVE_STRUCT_STATVFS_F_FSTYPENAME \
         || (! HAVE_STRUCT_STATFS_F_FSTYPENAME && HAVE_STRUCT_STATVFS_F_TYPE)))
# define USE_STATVFS 1
#else
# define USE_STATVFS 0
#endif

Additional context

No response

[zyv]

"uname -a" does not tell you the distro and version, BTW.

Mostly I want to know the kernel version and architecture, which is what uname -a is for. Distribution and release can usually be deduced from this if needed for most common distributions. "Slackware 15" does not reveal the architecture, which is often relevant.

Do not be cute. [...] The problem YOU are experiencing [...] where you lifted it all from [...]

I would like to ask you to change your tone to a more friendly and relaxed one. I'm working on this project for fun, and I'm not enjoying this interaction.

[zyv]

@aborodin, can we maybe just move it to mc-get-fs-info.m4 and mention where this logic comes from? The comment is gone in the current master as far as I can see.