ALFMOB-161: Incorrect Wishlist Header when opened from bottom bar #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoPinhoMinder
changed the title
JoaoPinhoMinder
force-pushed
the
bug/ALFMOB-161-incorrect-wishlist-header-when-opened-from-bottom-bar
branch
from
02573cb to
3343293
Compare
The **Wishlist toolbar** was being defined in `WishlistView`, causing it to always use the same header. regardless of how the view was opened. **How it was fixed:** - Moved toolbar definition to `ViewFactory`, ensuring the correct header is applied based on whether the view is opened from the **bottom bar** or via a **push event**.
JoaoPinhoMinder
force-pushed
the
bug/ALFMOB-161-incorrect-wishlist-header-when-opened-from-bottom-bar
branch
from
3343293 to
14d5e51
Compare
reisdev
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://mindera.atlassian.net/browse/ALFMOB-161
Description
The Wishlist toolbar was being defined in
WishlistView, causing it to always use the same header. regardless of how the view was opened.How it was fixed:
ViewFactory, ensuring the correct header is applied based on whether the view is opened from the bottom bar or via a push event.Evidences