[DOP-24183] Highlight column lineage on click #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-24183
branch
from
774307f to
f1d56ca
Compare
dolfinus
force-pushed
the
feature/DOP-24183
branch
6 times, most recently
from
c94f4ec to
cdc193d
Compare
Zabilsya
reviewed
Mar 5, 2025
dolfinus
force-pushed
the
feature/DOP-24183
branch
from
cdc193d to
5e6f79b
Compare
Zabilsya
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on column lineage edge selects edge + both connected columns:
Clicking on column selects connected edges and related column:
Double clicking on edge or column selects all related edges and nodes, recursively. Almost like double clicking on regular edge or dataset/job node, but only related columns are highlighted.
Non-selected edge is gray and thin, but selected edge is light-blue and a bit thicker, to highlight it visually. Label has the same light-blue color.
Current solution is custom state for selection which is updated by node/edge clicking events, and then ReactFlow nodes/edges
.selectedvalue is updated to match this state. This is because ReactFlow doesn't know anything about columns, so we cannot get selection from its internal state.