Fix incorrect JSON formatting with llama #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason llama will try to be helpful and include a comment in the JSON format the prompts ask it to return which causes parsing issues. Added regex to replace everything from "//" to "\n" to ensure that we can properly parse the string to form a valid JSON. Also updated the prompt to remove any "'" as that caused parsing problems (though removing the comments should fix it too)
|
Thank you @Unobfucator! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason llama will try to be helpful and include a comment in the JSON format it returns which causes parsing issues (despite the best effort to tell it not to include any JSON comments). Added regex to replace everything from "//" to "\n" to ensure that we can properly parse the string to form a valid JSON.
Also updated the prompt to remove any "'" as that caused parsing problems (though removing the comments should fix it too)
From testing we no longer error out and continue on to try and send a transaction. Further work will be needed to maintain state on the data passed to the user.
Also as an extra, updated the gitignore to ignore some generated files.