Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dense layout issue #547

Open
MikeKholomeev opened this issue May 10, 2023 · 7 comments
Open

Dense layout issue #547

MikeKholomeev opened this issue May 10, 2023 · 7 comments

Comments

@MikeKholomeev
Copy link

Hi all.

Is it possible to do smth with long paths in the list of the changed files?
Like at the screen below (it was made in fullscreen mode)

image

@Murmele
Copy link
Owner

Murmele commented May 10, 2023

Maybe a tooltip can be used like in the repository view. Or you can switch to the tree view view

@gh-devnull
Copy link
Contributor

Although far less useful than @Murmele's comment, I've thought about separating the file name and path so that each would be in their own column, something like this:
image
The columns could be resized and reordered. Obviously, this only makes sense in the view mode which @MikeKholomeev shows in his original comment.

I can offer no code to make this idea a reality yet, though it is on my To-Do list. Whether it comes off due to my own action or someone else's implementation of something comparable or better, I won't dare to say. 😁

@MikeKholomeev
Copy link
Author

MikeKholomeev commented May 11, 2023

Maybe a tooltip can be used like in the repository view. Or you can switch to the tree view view

I've thought about separating the file name and path

It's not usable.

I prefer removing the path part.

Usually, filenames are long enough to barely fit into the existing window width. So I'd prefer not to steal the width.

OR

Make it possible to narrow the branch-tree part

@RokeJulianLockhart
Copy link

@gh-devnull, a table is definitely the best solution.

gh-devnull added a commit to gh-devnull/Gittyup that referenced this issue Aug 31, 2023
…as a list in TreeViews.

Resolves  Dense layout issue Murmele#547
gh-devnull added a commit to gh-devnull/Gittyup that referenced this issue Aug 31, 2023
…nd state when files are shown as a list in TreeViews. Resolves Dense layout issue Murmele#547
gh-devnull added a commit to gh-devnull/Gittyup that referenced this issue Aug 31, 2023
…as a list in TreeViews. Resolves Dense layout issue Murmele#547
gh-devnull added a commit to gh-devnull/Gittyup that referenced this issue Aug 31, 2023
…as a list in TreeViews. Resolves Dense layout issue Murmele#547
@gh-devnull
Copy link
Contributor

I've added PR 632 with my implementation of this.

@gh-devnull
Copy link
Contributor

I forgot to mention here that I've subsequently added the ability to sort by column header. Column header widths can be adjusted too, which should help address @MikeKholomeev's comment.

@Murmele, these changes are available for review.

@Murmele
Copy link
Owner

Murmele commented Oct 9, 2023

@gh-devnull Thanks I will have a look into it. Sorry currently I am quite busy, so it will its time. And first I wanna merge the Qt6 feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants