wallet-ext: disconnect dapp popup

[pchrysochoidis]

Screen.Recording.2022-09-19.at.09.11.19.mov

closes #4696

[github-actions]

💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3085205245#artifacts

[Jordan-Mysten]

Popper has a successor called Floating UI, which I'd use if you can instead: https://floating-ui.com/

[pchrysochoidis]

Oh cool looks fancy! I am not familiar and I have limited time today, do you think changing it in another PR would be ok? (I will create an issue to track it)

[Jordan-Mysten]

Clear kind of implies removing all, maybe call this delete?

[pchrysochoidis]

Done

[mystie711]

@pchrysochoidis don't have opinion's on the floater ui Jordan speaks of. It did remind me of the need to add a gentle animation to the popup that appears on tap in header.

Could we add a gentle (300ms) "fade-in + grow" animation for the the Disconnect ui on-click?

[pchrysochoidis]

@pchrysochoidis don't have opinion's on the floater ui Jordan speaks of. It did remind me of the need to add a gentle animation to the popup that appears on tap in header.

Could we add a gentle (300ms) "fade-in + grow" animation for the the Disconnect ui on-click?

Yeah I remember our discussion but I think we decided that we can go without the animation first and add them as a next step. I will add an issue to track this.

Is this ok with you @mystie711? (Merge this without animations now and improve it with another PR)

[Jordan-Mysten]

Code LGTM. If you have time to add the animation, feel free to do so, but also feel free to punt to the next release if it'll take too long.

[pchrysochoidis]

Code LGTM. If you have time to add the animation, feel free to do so, but also feel free to punt to the next release if it'll take too long.

I will postpone it to the next release, to make sure we have the feature in this release and continue with the improvements.

[mystie711]

Agreed to tackle animation in a separate task with @pchrysochoidis .