bugfix on harvesting of unoccupied canopy area

[ckoven]

FATES is currently underestimating harvest rates relative to the forcing dataset, because it isn't transferring the correct amount of unoccupied space between tree crowns to the newly-logged patch when it applies harvest. This is because of a bug in some of the logic handling the edge case for when the forcing file specifies too-tiny logging rates, which is mistakenly zeroing out the rate of logging that is applied to the interstitial area. This PR fixes that.

Description:

There is logic to handle the case when the resulting secondary forest area would be smaller than the minimum FATES patch size. There is a mistaken else in that logic that shouldn't be there.

Collaborators:

Expectation of Answer Changes:

This will change answers when logging is active.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

• The in-code documentation has been updated with descriptive comments
• The documentation has been assessed to determine if updates are necessary

Integrator

• FATES PASS/FAIL regression tests were run
• Evaluation of test results for answer changes was performed and results provided

Documentation

• Technical Note update:
• User's Guide update:

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output: