Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button Component #198

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Button Component #198

merged 4 commits into from
Nov 7, 2024

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Oct 30, 2024 •
edited
Loading

Closes #19
Screenshot 2024-11-01 at 13 24 54

@thePeras
Copy link
Member Author

In order to style the new button, I needed to remove the default button style in simpler.css file. This breaks the Sigarra buttons.
What should I do? Should we create a script to substitute all the Sigarra buttons?

@thePeras
Copy link
Member Author

Inspiration coming from nextui button

@thePeras thePeras marked this pull request as ready for review November 1, 2024 13:26
toni-santos
toni-santos approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@toni-santos toni-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 👍

@thePeras thePeras merged commit b44fdfa into develop Nov 7, 2024
2 checks passed
@thePeras thePeras deleted the component/button branch November 7, 2024 20:43
@toni-santos toni-santos mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toni-santos toni-santos toni-santos approved these changes

@SimaoNery SimaoNery Awaiting requested review from SimaoNery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign buttons
2 participants
@thePeras @toni-santos