Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the current snapshot even if there is no delta. #940

Merged
merged 1 commit into from
Mar 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/payload/history.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,26 +74,28 @@ impl SharedHistory {

let mut history = self.write();
history.metrics = Some(metrics.into());
if let Some(delta) = delta {
let res = if let Some(delta) = delta {
// Data has changed.
info!(
"Delta with {} announced and {} withdrawn items.",
delta.announce_len(),
delta.withdraw_len(),
);
history.current = Some(snapshot.into());
history.push_delta(delta);
true
}
else if current.is_none() {
// This is the first snapshot ever.
history.current = Some(snapshot.into());
true
}
else {
// Nothing has changed.
false
}
};
// Update the snapshot. The refresh time and object information may
// have changed.
history.current = Some(snapshot.into());
res
}

/// Marks the beginning of an update cycle.
Expand Down
Loading