Incorrect version specification for some dependencies in setup.py #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alities on version numbers with an asterisk anymore.
jordanperr
changed the title
RHammond2
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request should fix the "extras_requires" error during pip install by modifying some version clauses in our setup.py file to use the inclusive ordered comparison.
Observed Behavior
Error observed on pip install:
error in OpenOA setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.Explaination
We had been incorrectly specifying some of our dependencies in setup.py. Past version of pip must have been more forgiving.
Example of incorrect version clause:
matplotlib>=3.6.*Instead, use:
matplotlib~=3.6matplotlib>=3.6See: pypa/setuptools#3801
Changes
In this pull request I modify the version specifiers in OpenOA to use the inclusive ordered comparison.