Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom road network #119

Merged
merged 6 commits into from
Dec 5, 2022
Merged

custom road network #119

merged 6 commits into from
Dec 5, 2022

Conversation

nreinicke
Copy link
Collaborator

Updates how we initialize a simulation to support injection of a custom road network at the highest level.

Now, an extension to the core library could call run_sim() and pass a set of custom initialization functions.

@nreinicke nreinicke requested a review from a user December 1, 2022 20:51
Copy link
Collaborator

@robfitzgerald robfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smooth. just a comment on a deleted test, but i think this all looks swell.

@robfitzgerald
Copy link
Collaborator

robfitzgerald commented Dec 5, 2022

@nreinicke hey, actually, should an init function be also allowed to update the Environment?

edit: for example, if a user wanted to inject their own custom mechatronics function

@nreinicke
Copy link
Collaborator Author

Yes, good point on the modification of the environment, I just added that in

Copy link
Collaborator

@robfitzgerald robfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥃

@nreinicke nreinicke merged commit 1548f52 into main Dec 5, 2022
@nreinicke nreinicke deleted the ndr/custom-road-network branch December 5, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants