make units an enum #120
Merged
make units an enum #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfitzgerald
requested changes
Dec 13, 2022
nrel/hive/model/vehicle/mechatronics/powertrain/tabular_powertrain.py
Outdated
Show resolved
Hide resolved
robfitzgerald
previously approved these changes
Dec 13, 2022
|
@robfitzgerald - sorry! I pushed up a change right as you were approving the PR. Do you mind taking a super brief look at a2281be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the units in hive a bit to support more ways to represent units as strings. Now, units are converted from a string into an Unit enum. This was done to support some internal work to integrate routee powertrain.