Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip charge instructions with no valid stations #142

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

robfitzgerald
Copy link
Collaborator

this PR checks if there are any valid stations before starting a charging station search.

added a scenario with no stations for testing it.

Closes #141.

@robfitzgerald robfitzgerald requested a review from nreinicke March 14, 2023 22:00
Copy link
Collaborator

@nreinicke nreinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense to me

@nreinicke nreinicke merged commit 273859c into main Mar 16, 2023
@nreinicke nreinicke mentioned this pull request Mar 16, 2023
@robfitzgerald robfitzgerald deleted the rjf/no-stations-charger-search branch April 25, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't search for chargers if there are no stations
2 participants