Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ndr/update link speed #200

Merged
merged 4 commits into from
May 1, 2023
Merged

Ndr/update link speed #200

merged 4 commits into from
May 1, 2023

Conversation

nreinicke
Copy link
Collaborator

closes #26 by updating a link traversal with the current speed from the road network at the time of traversal.

this also touches almost all the test files since we have pre-commit installed now and since I updated one test, I had to recursively go through all the tests and fix them to get the pre-commit hooks to let me submit this.

@robfitzgerald
Copy link
Collaborator

this also touches almost all the test files since we have pre-commit installed now

i don't think i know the whole story here, so, maybe could you explicitly list the things i should be looking for in my review?

@nreinicke
Copy link
Collaborator Author

Yeah sorry I should have explained more. Since we added precommit, each time you edit a file, it runs the linter against it and requires a fix before it will allow you to check the code in. When writing tests for this update, I had to modify the mock lobster file which gets imported by almost all the test files and so it led to me having to tweak all of those files to satisfy the linter.

All that being said, you should be able to just look at the following three files:

  • routetraversal.py
  • vehicle_state_ops.py
  • test_routetraversal.py

@nreinicke
Copy link
Collaborator Author

Also, to be explicit about the substantive changes, I just modified the traverse function to take the road network into scope and then get the link speed from the network at the time of a single link traversal.

Copy link
Collaborator

@robfitzgerald robfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. one step closer to speeds by time of day!

@nreinicke nreinicke merged commit be6958b into main May 1, 2023
@nreinicke nreinicke deleted the ndr/update-link-speed branch May 1, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derive link speed from road network
2 participants