Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: review status handling #511

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

csmig
Copy link
Member

@csmig csmig commented Nov 15, 2021

Resolves #380
Resolves #436
Resolves #481
Resolves #482
Resolves #502
Resolves #503
Resolves #508

Includes a MySQL migration that changes the schema for tables review and reviewHistory and drops table action.

  • UI: Collection metadata statusSettings includes resetCriteria (enum: result, any)
  • API: validate Reviews against Collection metadata fieldSettings and statusSettings
  • API: Review property resultComment => detail
  • API: Review property actionComment => comment
  • API: remove Review property action
  • OAS: updated Review schemas
  • Tests: test data conforms to OAS changes
  • UI: various enhancements and refactoring

@csmig csmig merged commit 6663133 into NUWCDIVNPT:main Nov 16, 2021
@csmig csmig deleted the api-review-changes-pr branch November 16, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment