Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse and import XCCDF with root-level TestResult #931

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

csmig
Copy link
Member

@csmig csmig commented Feb 28, 2023

Resolves: #890

This code successfully processes the sanitized sample files from ACAS and HBSS which were provided with #890. We need additional feedback from the community to establish we can handle all of the real-world XCCDF from those tools.

This PR handles the non-standard value for <TestResult test-system> that is seen in the HBSS file. According to the XCCDF specification the test-system attribute "SHOULD be either a CPE name or a CPE applicability language expression", but HBSS does not follow this suggestion and our existing code expected a CPE name.

Unlike SCC and OpenSCAP, neither ACAS nor HBSS provide a timestamp for each <rule-result>. I've instead used the required attribute <TestResult end-time> as a common timestamp for each result.

@csmig csmig requested a review from cd-rite February 28, 2023 18:33
@csmig csmig merged commit 45d9946 into NUWCDIVNPT:main Mar 1, 2023
@csmig csmig deleted the xccdf-import branch March 1, 2023 19:19
@ronaldsimmons
Copy link

@csmig Thank you, all I need the Cloud One team to do now is do a pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import XCCDF with root-level TestResult
2 participants