Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: handle missing cci and include all ccis #971

Merged
merged 1 commit into from
Apr 13, 2023
Merged

hotfix: handle missing cci and include all ccis #971

merged 1 commit into from
Apr 13, 2023

Conversation

csmig
Copy link
Member

@csmig csmig commented Apr 13, 2023

Resolves #969

Updates the handler for GET /collections/{collectionId}/findings, which was regressed by #936 such that Rules without a CCI mapping were not being returned.

Updates the OAS to allow null values for cci name, description, and apAcronym.

Updates the handler for POST /stigs which was regressed by #936 such that only the first occurrence of a CCI in a Benchmark was mapped to a single rule.

@csmig csmig merged commit 2aa3860 into NUWCDIVNPT:main Apr 13, 2023
csmig added a commit to csmig/stig-manager that referenced this pull request Apr 14, 2023
@csmig
Squashed commit of the following:
644a716 
commit 21bf9b3
Author: csmig <[email protected]>
Date:   Fri Apr 14 16:13:09 2023 +0000

    fix: include client node_mdules in container builds (NUWCDIVNPT#979)

commit 9535b76
Author: cd-rite <[email protected]>
Date:   Thu Apr 13 19:21:37 2023 -0400

    chore: 1.3.4 (NUWCDIVNPT#978)

commit ad8f2e8
Author: cd-rite <[email protected]>
Date:   Thu Apr 13 19:12:09 2023 -0400

    user admin -> user properties -> collection grants grid not allowing owner mods (NUWCDIVNPT#977)

commit da170e2
Author: cd-rite <[email protected]>
Date:   Thu Apr 13 18:51:24 2023 -0400

    switched to iron bank node-slim base image, updated upload-artifact actions to v3 (NUWCDIVNPT#975)

commit 3685cae
Author: cd-rite <[email protected]>
Date:   Thu Apr 13 18:40:25 2023 -0400

    remove asmCrypto, replace with native browser functions (NUWCDIVNPT#972)

commit 75e0e82
Author: csmig <[email protected]>
Date:   Thu Apr 13 22:28:23 2023 +0000

    refactor: web app error handling (NUWCDIVNPT#968)

    * refactor: web app error handling

    * remove unneeded JSON.parse

    * global variable STIGMAN.apiConfig

    ---------

    Co-authored-by: csmig <[email protected]>

commit 2aa3860
Author: csmig <[email protected]>
Date:   Thu Apr 13 21:14:31 2023 +0000

    hotfix: handle missing cci and include all ccis (NUWCDIVNPT#971)

commit b191c33
Author: csmig <[email protected]>
Date:   Thu Apr 13 11:35:41 2023 +0000

    refactor: collection checklist query (NUWCDIVNPT#967)
csmig added a commit to csmig/stig-manager that referenced this pull request Apr 27, 2023
@csmig
Squashed commit of the following:
9d93af0 
commit f4ba951
Merge: c0a339e 3517151
Author: cd-rite <[email protected]>
Date:   Thu Apr 27 10:00:41 2023 -0400

    Merge branch '1.3.5' of https://github.com/csmig/stig-manager into 1.3.5

commit c0a339e
Author: cd-rite <[email protected]>
Date:   Thu Apr 27 09:59:55 2023 -0400

    added reviewKeyChange test file

commit 3517151
Author: csmig <[email protected]>
Date:   Wed Apr 26 15:12:23 2023 -0400

    squashed merge of main

commit 1ef17b7
Author: csmig <[email protected]>
Date:   Wed Apr 26 14:44:47 2023 -0400

    bump version to 1.3.5-rc.2

commit 32d003f
Author: csmig <[email protected]>
Date:   Wed Apr 26 14:44:05 2023 -0400

    migration does not delete reviews or history

commit 873778a
Author: cd-rite <[email protected]>
Date:   Mon Apr 24 17:01:59 2023 -0400

    docs updates for review-key change

commit bab587e
Author: cd-rite <[email protected]>
Date:   Mon Apr 24 17:00:00 2023 -0400

    Added tests, uncommented ruleIds properties in spec, return empty arrya instead of null for stigs projection, delete from rule_version_check_digest when deleting stigs.

commit ae59286
Author: csmig <[email protected]>
Date:   Thu Apr 20 20:31:56 2023 -0400

    bump version to 1.3.5-rc.1

commit 0d9b722
Author: csmig <[email protected]>
Date:   Thu Apr 20 20:21:36 2023 -0400

    merge oidc-refactor

commit cce4dda
Author: csmig <[email protected]>
Date:   Thu Apr 20 20:14:18 2023 -0400

    new columns NOT NULL; preserve/delete with unmatched rule

commit ed4ab2f
Author: csmig <[email protected]>
Date:   Wed Apr 19 14:49:50 2023 -0400

    add ruleId to history records

commit 56290b3
Author: csmig <[email protected]>
Date:   Wed Apr 19 12:10:22 2023 -0400

    client: ruleId sprite and tooltip

commit ecd67e6
Author: csmig <[email protected]>
Date:   Mon Apr 17 15:36:19 2023 -0400

    putReviewsByAsset partition by version/checkDIgest

commit 9caf65b
Author: csmig <[email protected]>
Date:   Sun Apr 16 20:24:12 2023 -0400

    preserve and delete duplicate reviews

commit cc66539
Author: csmig <[email protected]>
Date:   Sun Apr 16 18:54:44 2023 -0400

    appdata imports reviews into temp table

commit b1bb4ce
Author: csmig <[email protected]>
Date:   Sat Apr 15 13:51:48 2023 -0400

    newman passes; commented ruleIds property

commit 3337c07
Author: csmig <[email protected]>
Date:   Sat Apr 15 13:25:15 2023 -0400

    newman fails 2

commit 644a716
Author: csmig <[email protected]>
Date:   Fri Apr 14 18:18:42 2023 -0400

    Squashed commit of the following:

    commit 21bf9b3
    Author: csmig <[email protected]>
    Date:   Fri Apr 14 16:13:09 2023 +0000

        fix: include client node_mdules in container builds (NUWCDIVNPT#979)

    commit 9535b76
    Author: cd-rite <[email protected]>
    Date:   Thu Apr 13 19:21:37 2023 -0400

        chore: 1.3.4 (NUWCDIVNPT#978)

    commit ad8f2e8
    Author: cd-rite <[email protected]>
    Date:   Thu Apr 13 19:12:09 2023 -0400

        user admin -> user properties -> collection grants grid not allowing owner mods (NUWCDIVNPT#977)

    commit da170e2
    Author: cd-rite <[email protected]>
    Date:   Thu Apr 13 18:51:24 2023 -0400

        switched to iron bank node-slim base image, updated upload-artifact actions to v3 (NUWCDIVNPT#975)

    commit 3685cae
    Author: cd-rite <[email protected]>
    Date:   Thu Apr 13 18:40:25 2023 -0400

        remove asmCrypto, replace with native browser functions (NUWCDIVNPT#972)

    commit 75e0e82
    Author: csmig <[email protected]>
    Date:   Thu Apr 13 22:28:23 2023 +0000

        refactor: web app error handling (NUWCDIVNPT#968)

        * refactor: web app error handling

        * remove unneeded JSON.parse

        * global variable STIGMAN.apiConfig

        ---------

        Co-authored-by: csmig <[email protected]>

    commit 2aa3860
    Author: csmig <[email protected]>
    Date:   Thu Apr 13 21:14:31 2023 +0000

        hotfix: handle missing cci and include all ccis (NUWCDIVNPT#971)

    commit b191c33
    Author: csmig <[email protected]>
    Date:   Thu Apr 13 11:35:41 2023 +0000

        refactor: collection checklist query (NUWCDIVNPT#967)

commit 1f27adf
Author: csmig <[email protected]>
Date:   Thu Apr 13 13:20:27 2023 -0400

    wip

commit f7f7606
Author: csmig <[email protected]>
Date:   Thu Apr 13 07:36:44 2023 -0400

    Squashed commit of the following:

    commit b191c33
    Author: csmig <[email protected]>
    Date:   Thu Apr 13 11:35:41 2023 +0000

        refactor: collection checklist query (NUWCDIVNPT#967)

commit db2699a
Author: csmig <[email protected]>
Date:   Wed Apr 12 20:33:31 2023 -0400

    nightly

commit fd3d5b5
Author: csmig <[email protected]>
Date:   Wed Apr 12 10:03:10 2023 -0400

    migration, stats, and asset checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection Analytics/Statistics Incorrect
1 participant
@csmig