-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework CUDA compiler checks #3057
Merged
bernhardmgruber
merged 7 commits into
NVIDIA:main
from
davebayer:rework_cuda_compiler_checks
Dec 5, 2024
Merged
Rework CUDA compiler checks #3057
bernhardmgruber
merged 7 commits into
NVIDIA:main
from
davebayer:rework_cuda_compiler_checks
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed some minor issues with comments
/ok to test |
/ok to test |
🟩 CI finished in 2h 12m: Pass: 100%/396 | Total: 3d 02h | Avg: 11m 20s | Max: 1h 20m | Hits: 10%/22125
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 396)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
26 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
bernhardmgruber
approved these changes
Dec 5, 2024
Thank you for this improvement! |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Michael Schellenberger Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new CUDA compiler handling, following the C++ compiler checks.
Changes:
_CCCL_CUDA_COMPILER_{NAME}
macros now expands to the CUDA compiler version, same as the c++ compilers, e. g. for NVHPC compiler:_CCCL_COMPILER_NVHPC == _CCCL_CUDA_COMPILER_NVHPC
_CCCL_CUDA_COMPILER(NAME [, OP, MAJ [, MIN]])
macro, same as way as for the C++ compilers_CCCL_CUDACC
expands to the CUDA Toolkit version (that's what_CCCL_CUDACC_VER
did in the past)_CCCL_CUDACC_{BELOW,AT_LEAST}
now allows omiting the minor version_CCCL_CUDA_COMPILER
macro is now always defined and the old behaviour is replaced by the_CCCL_HAS_CUDA_COMPILER
macro to avoid naming issues