Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of DispatchSelectIf parameterization #3092

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Improve readability of DispatchSelectIf parameterization #3092

merged 2 commits into from
Dec 9, 2024

Conversation

bernhardmgruber
Copy link
Contributor

@gonidelis and I got a bit confused tracing parameter names through the code, so here is a small improvement.

@bernhardmgruber bernhardmgruber requested review from a team as code owners December 9, 2024 13:46
elstehle
elstehle approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@elstehle elstehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

🟩 CI finished in 1h 26m: Pass: 100%/94 | Total: 1d 09h | Avg: 21m 38s | Max: 55m 39s | Hits: 93%/12288

  • 🟩 thrust: Pass: 100%/46 | Total: 7h 10m | Avg: 9m 21s | Max: 34m 06s | Hits: 92%/9260 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 21m 03s | Avg: 10m 31s | Max: 14m 48s
🟩 cpu
  🟩 amd64              Pass: 100%/44  | Total:  7h 00m | Avg:  9m 33s | Max: 34m 06s | Hits:  92%/9260  
  🟩 arm64              Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  5m 12s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total:  1h 11m | Avg: 10m 13s | Max: 28m 05s | Hits:  91%/1852  
  🟩 12.5               Pass: 100%/2   | Total: 40m 41s | Avg: 20m 20s | Max: 20m 34s
  🟩 12.6               Pass: 100%/37  | Total:  5h 18m | Avg:  8m 36s | Max: 34m 06s | Hits:  93%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 58s | Avg:  4m 59s | Max:  5m 00s
  🟩 nvcc11.1           Pass: 100%/7   | Total:  1h 11m | Avg: 10m 13s | Max: 28m 05s | Hits:  91%/1852  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 40m 41s | Avg: 20m 20s | Max: 20m 34s
  🟩 nvcc12.6           Pass: 100%/35  | Total:  5h 08m | Avg:  8m 48s | Max: 34m 06s | Hits:  93%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 58s | Avg:  4m 59s | Max:  5m 00s
  🟩 nvcc               Pass: 100%/44  | Total:  7h 00m | Avg:  9m 33s | Max: 34m 06s | Hits:  92%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total: 21m 43s | Avg:  5m 25s | Max:  6m 38s
  🟩 Clang10            Pass: 100%/1   | Total:  6m 57s | Avg:  6m 57s | Max:  6m 57s
  🟩 Clang11            Pass: 100%/1   | Total:  5m 43s | Avg:  5m 43s | Max:  5m 43s
  🟩 Clang12            Pass: 100%/1   | Total:  5m 37s | Avg:  5m 37s | Max:  5m 37s
  🟩 Clang13            Pass: 100%/1   | Total:  5m 03s | Avg:  5m 03s | Max:  5m 03s
  🟩 Clang14            Pass: 100%/1   | Total:  5m 13s | Avg:  5m 13s | Max:  5m 13s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 11s | Avg:  5m 11s | Max:  5m 11s
  🟩 Clang16            Pass: 100%/1   | Total:  6m 24s | Avg:  6m 24s | Max:  6m 24s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 16s | Avg:  5m 16s | Max:  5m 16s
  🟩 Clang18            Pass: 100%/7   | Total: 45m 15s | Avg:  6m 27s | Max: 12m 10s
  🟩 GCC6               Pass: 100%/2   | Total: 25m 24s | Avg: 12m 42s | Max: 21m 06s
  🟩 GCC7               Pass: 100%/2   | Total: 10m 15s | Avg:  5m 07s | Max:  5m 25s
  🟩 GCC8               Pass: 100%/1   | Total:  6m 12s | Avg:  6m 12s | Max:  6m 12s
  🟩 GCC9               Pass: 100%/3   | Total: 15m 41s | Avg:  5m 13s | Max:  6m 44s
  🟩 GCC10              Pass: 100%/1   | Total:  5m 10s | Avg:  5m 10s | Max:  5m 10s
  🟩 GCC11              Pass: 100%/1   | Total:  5m 29s | Avg:  5m 29s | Max:  5m 29s
  🟩 GCC12              Pass: 100%/1   | Total:  5m 36s | Avg:  5m 36s | Max:  5m 36s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 03m | Avg:  7m 59s | Max: 14m 48s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total:  6m 51s | Avg:  6m 51s | Max:  6m 51s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 28m 05s | Avg: 28m 05s | Max: 28m 05s | Hits:  91%/1852  
  🟩 MSVC14.29          Pass: 100%/1   | Total: 22m 33s | Avg: 22m 33s | Max: 22m 33s | Hits:  93%/1852  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  1h 22m | Avg: 27m 30s | Max: 34m 06s | Hits:  93%/5556  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 40m 41s | Avg: 20m 20s | Max: 20m 34s
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total:  1h 52m | Avg:  5m 54s | Max: 12m 10s
  🟩 GCC                Pass: 100%/19  | Total:  2h 17m | Avg:  7m 14s | Max: 21m 06s
  🟩 Intel              Pass: 100%/1   | Total:  6m 51s | Avg:  6m 51s | Max:  6m 51s
  🟩 MSVC               Pass: 100%/5   | Total:  2h 13m | Avg: 26m 38s | Max: 34m 06s | Hits:  92%/9260  
  🟩 NVHPC              Pass: 100%/2   | Total: 40m 41s | Avg: 20m 20s | Max: 20m 34s
🟩 gpu
  🟩 v100               Pass: 100%/46  | Total:  7h 10m | Avg:  9m 21s | Max: 34m 06s | Hits:  92%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/40  | Total:  5h 53m | Avg:  8m 50s | Max: 34m 06s | Hits:  91%/7408  
  🟩 TestCPU            Pass: 100%/3   | Total: 36m 31s | Avg: 12m 10s | Max: 22m 00s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/3   | Total: 40m 49s | Avg: 13m 36s | Max: 14m 48s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 54s | Avg:  4m 54s | Max:  4m 54s
🟩 std
  🟩 11                 Pass: 100%/5   | Total: 39m 54s | Avg:  7m 58s | Max: 21m 06s
  🟩 14                 Pass: 100%/4   | Total: 44m 26s | Avg: 11m 06s | Max: 28m 05s | Hits:  91%/1852  
  🟩 17                 Pass: 100%/12  | Total:  2h 02m | Avg: 10m 13s | Max: 26m 26s | Hits:  92%/3704  
  🟩 20                 Pass: 100%/23  | Total:  3h 22m | Avg:  8m 48s | Max: 34m 06s | Hits:  94%/3704

  • 🟩 cub: Pass: 100%/45 | Total: 1d 02h | Avg: 34m 49s | Max: 55m 39s | Hits: 96%/3028 

    🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  1d 00h | Avg: 34m 22s | Max: 55m 39s | Hits:  96%/3028  
  🟩 arm64              Pass: 100%/2   | Total:  1h 29m | Avg: 44m 43s | Max: 48m 09s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total:  3h 53m | Avg: 33m 17s | Max: 46m 29s | Hits:  95%/757   
  🟩 12.5               Pass: 100%/2   | Total:  1h 20m | Avg: 40m 09s | Max: 40m 43s
  🟩 12.6               Pass: 100%/36  | Total: 20h 54m | Avg: 34m 50s | Max: 55m 39s | Hits:  96%/2271  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 45m | Avg: 52m 58s | Max: 55m 39s
  🟩 nvcc11.1           Pass: 100%/7   | Total:  3h 53m | Avg: 33m 17s | Max: 46m 29s | Hits:  95%/757   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 20m | Avg: 40m 09s | Max: 40m 43s
  🟩 nvcc12.6           Pass: 100%/34  | Total: 19h 08m | Avg: 33m 46s | Max: 50m 49s | Hits:  96%/2271  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 45m | Avg: 52m 58s | Max: 55m 39s
  🟩 nvcc               Pass: 100%/43  | Total:  1d 00h | Avg: 33m 59s | Max: 50m 49s | Hits:  96%/3028  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total:  2h 10m | Avg: 32m 39s | Max: 36m 23s
  🟩 Clang10            Pass: 100%/1   | Total: 36m 24s | Avg: 36m 24s | Max: 36m 24s
  🟩 Clang11            Pass: 100%/1   | Total: 35m 22s | Avg: 35m 22s | Max: 35m 22s
  🟩 Clang12            Pass: 100%/1   | Total: 33m 24s | Avg: 33m 24s | Max: 33m 24s
  🟩 Clang13            Pass: 100%/1   | Total: 34m 31s | Avg: 34m 31s | Max: 34m 31s
  🟩 Clang14            Pass: 100%/1   | Total: 34m 49s | Avg: 34m 49s | Max: 34m 49s
  🟩 Clang15            Pass: 100%/1   | Total: 33m 30s | Avg: 33m 30s | Max: 33m 30s
  🟩 Clang16            Pass: 100%/1   | Total: 38m 04s | Avg: 38m 04s | Max: 38m 04s
  🟩 Clang17            Pass: 100%/1   | Total: 34m 12s | Avg: 34m 12s | Max: 34m 12s
  🟩 Clang18            Pass: 100%/7   | Total:  4h 27m | Avg: 38m 13s | Max: 55m 39s
  🟩 GCC6               Pass: 100%/2   | Total:  1h 02m | Avg: 31m 05s | Max: 31m 19s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 11m | Avg: 35m 52s | Max: 37m 54s
  🟩 GCC8               Pass: 100%/1   | Total: 36m 56s | Avg: 36m 56s | Max: 36m 56s
  🟩 GCC9               Pass: 100%/3   | Total:  1h 37m | Avg: 32m 39s | Max: 33m 59s
  🟩 GCC10              Pass: 100%/1   | Total: 34m 41s | Avg: 34m 41s | Max: 34m 41s
  🟩 GCC11              Pass: 100%/1   | Total: 37m 55s | Avg: 37m 55s | Max: 37m 55s
  🟩 GCC12              Pass: 100%/1   | Total: 38m 42s | Avg: 38m 42s | Max: 38m 42s
  🟩 GCC13              Pass: 100%/8   | Total:  3h 19m | Avg: 24m 55s | Max: 48m 09s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total: 36m 17s | Avg: 36m 17s | Max: 36m 17s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 46m 29s | Avg: 46m 29s | Max: 46m 29s | Hits:  95%/757   
  🟩 MSVC14.29          Pass: 100%/1   | Total: 45m 51s | Avg: 45m 51s | Max: 45m 51s | Hits:  96%/757   
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 40m | Avg: 50m 13s | Max: 50m 49s | Hits:  96%/1514  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 20m | Avg: 40m 09s | Max: 40m 43s
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total: 11h 18m | Avg: 35m 42s | Max: 55m 39s
  🟩 GCC                Pass: 100%/19  | Total:  9h 39m | Avg: 30m 30s | Max: 48m 09s
  🟩 Intel              Pass: 100%/1   | Total: 36m 17s | Avg: 36m 17s | Max: 36m 17s
  🟩 MSVC               Pass: 100%/4   | Total:  3h 12m | Avg: 48m 11s | Max: 50m 49s | Hits:  96%/3028  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 20m | Avg: 40m 09s | Max: 40m 43s
🟩 gpu
  🟩 v100               Pass: 100%/45  | Total:  1d 02h | Avg: 34m 49s | Max: 55m 39s | Hits:  96%/3028  
🟩 jobs
  🟩 Build              Pass: 100%/39  | Total:  1d 00h | Avg: 37m 13s | Max: 55m 39s | Hits:  96%/3028  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 17m 27s | Avg: 17m 27s | Max: 17m 27s
  🟩 GraphCapture       Pass: 100%/1   | Total: 18m 42s | Avg: 18m 42s | Max: 18m 42s
  🟩 HostLaunch         Pass: 100%/2   | Total: 36m 52s | Avg: 18m 26s | Max: 18m 53s
  🟩 TestGPU            Pass: 100%/2   | Total: 42m 34s | Avg: 21m 17s | Max: 22m 11s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 25s | Avg:  4m 25s | Max:  4m 25s
🟩 std
  🟩 11                 Pass: 100%/5   | Total:  2h 41m | Avg: 32m 19s | Max: 36m 23s
  🟩 14                 Pass: 100%/4   | Total:  2h 29m | Avg: 37m 23s | Max: 46m 29s | Hits:  95%/757   
  🟩 17                 Pass: 100%/12  | Total:  7h 50m | Avg: 39m 12s | Max: 55m 39s | Hits:  97%/1514  
  🟩 20                 Pass: 100%/24  | Total: 13h 05m | Avg: 32m 44s | Max: 50m 49s | Hits:  95%/757

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 08s | Avg: 5m 04s | Max: 7m 28s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  7m 28s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  7m 28s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  7m 28s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  7m 28s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  7m 28s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  7m 28s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 10m 08s | Avg:  5m 04s | Max:  7m 28s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 40s | Avg:  2m 40s | Max:  2m 40s
  🟩 Test               Pass: 100%/1   | Total:  7m 28s | Avg:  7m 28s | Max:  7m 28s

  • 🟩 python: Pass: 100%/1 | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 25m 54s | Avg: 25m 54s | Max: 25m 54s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 94)
# Runner
70 linux-amd64-cpu16
11 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16
4 linux-arm64-cpu16

@bernhardmgruber bernhardmgruber merged commit 1e5da8d into NVIDIA:main Dec 9, 2024
109 checks passed
@bernhardmgruber bernhardmgruber deleted the select_readab branch December 9, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstehle elstehle elstehle approved these changes

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

@fbusato fbusato Awaiting requested review from fbusato fbusato was automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernhardmgruber @elstehle