Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in the documentation of cub::DeviceReduce::Reduce #3123

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix a typo in the documentation of cub::DeviceReduce::Reduce #3123

merged 1 commit into from
Dec 11, 2024

Conversation

caugonnet
Copy link
Contributor

Description

The documentation of cub::DeviceReduce::Reduce was showing a custom operator which was implemented on the host rather than on the device

Checklist

  • I am familiar with the Contributing Guidelines.
  • [] New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@caugonnet caugonnet requested review from a team as code owners December 11, 2024 13:27
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@caugonnet
Fix a typo in the documentation cub::DeviceReduce::Reduce where the C…
4122dfa 
…ustomMin operator was implemented on __host__ instead of __device__
@caugonnet caugonnet force-pushed the cub_doc_fix_reduce_typo branch from 98a8821 to 4122dfa Compare December 11, 2024 13:28
@caugonnet
Copy link
Contributor Author

/ok to test

@miscco miscco enabled auto-merge (squash) December 11, 2024 13:36
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 47m 41s: Pass: 100%/94 | Total: 13h 40m | Avg: 8m 43s | Max: 41m 33s | Hits: 99%/12324

  • 🟩 thrust: Pass: 100%/46 | Total: 6h 24m | Avg: 8m 20s | Max: 25m 52s | Hits: 99%/9260 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 22m 23s | Avg: 11m 11s | Max: 16m 45s
🟩 cpu
  🟩 amd64              Pass: 100%/44  | Total:  6h 14m | Avg:  8m 30s | Max: 25m 52s | Hits:  99%/9260  
  🟩 arm64              Pass: 100%/2   | Total:  9m 42s | Avg:  4m 51s | Max:  5m 16s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total: 43m 46s | Avg:  6m 15s | Max: 17m 47s | Hits:  99%/1852  
  🟩 12.5               Pass: 100%/2   | Total: 27m 10s | Avg: 13m 35s | Max: 13m 47s
  🟩 12.6               Pass: 100%/37  | Total:  5h 13m | Avg:  8m 27s | Max: 25m 52s | Hits:  99%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 46s | Avg:  4m 53s | Max:  4m 58s
  🟩 nvcc11.1           Pass: 100%/7   | Total: 43m 46s | Avg:  6m 15s | Max: 17m 47s | Hits:  99%/1852  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 27m 10s | Avg: 13m 35s | Max: 13m 47s
  🟩 nvcc12.6           Pass: 100%/35  | Total:  5h 03m | Avg:  8m 40s | Max: 25m 52s | Hits:  99%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 46s | Avg:  4m 53s | Max:  4m 58s
  🟩 nvcc               Pass: 100%/44  | Total:  6h 14m | Avg:  8m 30s | Max: 25m 52s | Hits:  99%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total: 20m 41s | Avg:  5m 10s | Max:  6m 23s
  🟩 Clang10            Pass: 100%/1   | Total:  7m 10s | Avg:  7m 10s | Max:  7m 10s
  🟩 Clang11            Pass: 100%/1   | Total:  5m 35s | Avg:  5m 35s | Max:  5m 35s
  🟩 Clang12            Pass: 100%/1   | Total:  5m 08s | Avg:  5m 08s | Max:  5m 08s
  🟩 Clang13            Pass: 100%/1   | Total:  5m 26s | Avg:  5m 26s | Max:  5m 26s
  🟩 Clang14            Pass: 100%/1   | Total:  5m 29s | Avg:  5m 29s | Max:  5m 29s
  🟩 Clang15            Pass: 100%/1   | Total:  6m 04s | Avg:  6m 04s | Max:  6m 04s
  🟩 Clang16            Pass: 100%/1   | Total:  5m 38s | Avg:  5m 38s | Max:  5m 38s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 46s | Avg:  5m 46s | Max:  5m 46s
  🟩 Clang18            Pass: 100%/7   | Total: 57m 36s | Avg:  8m 13s | Max: 25m 05s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 18s | Avg:  4m 09s | Max:  4m 18s
  🟩 GCC7               Pass: 100%/2   | Total:  9m 43s | Avg:  4m 51s | Max:  5m 02s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 15s | Avg:  5m 15s | Max:  5m 15s
  🟩 GCC9               Pass: 100%/3   | Total: 14m 10s | Avg:  4m 43s | Max:  5m 26s
  🟩 GCC10              Pass: 100%/1   | Total:  5m 45s | Avg:  5m 45s | Max:  5m 45s
  🟩 GCC11              Pass: 100%/1   | Total:  6m 03s | Avg:  6m 03s | Max:  6m 03s
  🟩 GCC12              Pass: 100%/1   | Total:  5m 38s | Avg:  5m 38s | Max:  5m 38s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 18m | Avg:  9m 46s | Max: 25m 52s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total:  6m 42s | Avg:  6m 42s | Max:  6m 42s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 17m 47s | Avg: 17m 47s | Max: 17m 47s | Hits:  99%/1852  
  🟩 MSVC14.29          Pass: 100%/1   | Total: 15m 42s | Avg: 15m 42s | Max: 15m 42s | Hits:  99%/1852  
  🟩 MSVC14.39          Pass: 100%/3   | Total: 59m 09s | Avg: 19m 43s | Max: 22m 03s | Hits:  99%/5556  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 27m 10s | Avg: 13m 35s | Max: 13m 47s
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total:  2h 04m | Avg:  6m 33s | Max: 25m 05s
  🟩 GCC                Pass: 100%/19  | Total:  2h 13m | Avg:  7m 00s | Max: 25m 52s
  🟩 Intel              Pass: 100%/1   | Total:  6m 42s | Avg:  6m 42s | Max:  6m 42s
  🟩 MSVC               Pass: 100%/5   | Total:  1h 32m | Avg: 18m 31s | Max: 22m 03s | Hits:  99%/9260  
  🟩 NVHPC              Pass: 100%/2   | Total: 27m 10s | Avg: 13m 35s | Max: 13m 47s
🟩 gpu
  🟩 v100               Pass: 100%/46  | Total:  6h 24m | Avg:  8m 20s | Max: 25m 52s | Hits:  99%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/40  | Total:  4h 39m | Avg:  6m 59s | Max: 19m 34s | Hits:  99%/7408  
  🟩 TestCPU            Pass: 100%/3   | Total: 36m 57s | Avg: 12m 19s | Max: 22m 03s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 07m | Avg: 22m 34s | Max: 25m 52s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 49s | Avg:  4m 49s | Max:  4m 49s
🟩 std
  🟩 11                 Pass: 100%/5   | Total: 22m 15s | Avg:  4m 27s | Max:  5m 21s
  🟩 14                 Pass: 100%/4   | Total: 33m 30s | Avg:  8m 22s | Max: 17m 47s | Hits:  99%/1852  
  🟩 17                 Pass: 100%/12  | Total:  1h 36m | Avg:  8m 04s | Max: 17m 32s | Hits:  99%/3704  
  🟩 20                 Pass: 100%/23  | Total:  3h 29m | Avg:  9m 05s | Max: 25m 52s | Hits:  99%/3704

  • 🟩 cub: Pass: 100%/45 | Total: 6h 35m | Avg: 8m 47s | Max: 41m 33s | Hits: 99%/3064 

    🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  6h 26m | Avg:  8m 58s | Max: 41m 33s | Hits:  99%/3064  
  🟩 arm64              Pass: 100%/2   | Total:  9m 29s | Avg:  4m 44s | Max:  4m 58s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total: 40m 02s | Avg:  5m 43s | Max: 14m 51s | Hits:  99%/766   
  🟩 12.5               Pass: 100%/2   | Total: 18m 47s | Avg:  9m 23s | Max:  9m 45s
  🟩 12.6               Pass: 100%/36  | Total:  5h 36m | Avg:  9m 21s | Max: 41m 33s | Hits:  99%/2298  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  8m 41s | Avg:  4m 20s | Max:  4m 32s
  🟩 nvcc11.1           Pass: 100%/7   | Total: 40m 02s | Avg:  5m 43s | Max: 14m 51s | Hits:  99%/766   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 18m 47s | Avg:  9m 23s | Max:  9m 45s
  🟩 nvcc12.6           Pass: 100%/34  | Total:  5h 28m | Avg:  9m 38s | Max: 41m 33s | Hits:  99%/2298  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  8m 41s | Avg:  4m 20s | Max:  4m 32s
  🟩 nvcc               Pass: 100%/43  | Total:  6h 26m | Avg:  8m 59s | Max: 41m 33s | Hits:  99%/3064  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total: 20m 45s | Avg:  5m 11s | Max:  6m 18s
  🟩 Clang10            Pass: 100%/1   | Total:  6m 12s | Avg:  6m 12s | Max:  6m 12s
  🟩 Clang11            Pass: 100%/1   | Total:  5m 07s | Avg:  5m 07s | Max:  5m 07s
  🟩 Clang12            Pass: 100%/1   | Total:  5m 05s | Avg:  5m 05s | Max:  5m 05s
  🟩 Clang13            Pass: 100%/1   | Total:  5m 59s | Avg:  5m 59s | Max:  5m 59s
  🟩 Clang14            Pass: 100%/1   | Total:  5m 07s | Avg:  5m 07s | Max:  5m 07s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 51s | Avg:  5m 51s | Max:  5m 51s
  🟩 Clang16            Pass: 100%/1   | Total:  5m 15s | Avg:  5m 15s | Max:  5m 15s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 30s | Avg:  5m 30s | Max:  5m 30s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 25m | Avg: 12m 10s | Max: 41m 33s
  🟩 GCC6               Pass: 100%/2   | Total:  8m 26s | Avg:  4m 13s | Max:  4m 30s
  🟩 GCC7               Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  5m 22s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 05s | Avg:  5m 05s | Max:  5m 05s
  🟩 GCC9               Pass: 100%/3   | Total: 13m 31s | Avg:  4m 30s | Max:  5m 20s
  🟩 GCC10              Pass: 100%/1   | Total:  6m 22s | Avg:  6m 22s | Max:  6m 22s
  🟩 GCC11              Pass: 100%/1   | Total:  5m 16s | Avg:  5m 16s | Max:  5m 16s
  🟩 GCC12              Pass: 100%/1   | Total:  5m 57s | Avg:  5m 57s | Max:  5m 57s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 51m | Avg: 13m 55s | Max: 30m 13s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total:  7m 17s | Avg:  7m 17s | Max:  7m 17s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 14m 51s | Avg: 14m 51s | Max: 14m 51s | Hits:  99%/766   
  🟩 MSVC14.29          Pass: 100%/1   | Total: 12m 05s | Avg: 12m 05s | Max: 12m 05s | Hits:  99%/766   
  🟩 MSVC14.39          Pass: 100%/2   | Total: 25m 57s | Avg: 12m 58s | Max: 13m 27s | Hits:  99%/1532  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 18m 47s | Avg:  9m 23s | Max:  9m 45s
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total:  2h 30m | Avg:  7m 53s | Max: 41m 33s
  🟩 GCC                Pass: 100%/19  | Total:  2h 46m | Avg:  8m 46s | Max: 30m 13s
  🟩 Intel              Pass: 100%/1   | Total:  7m 17s | Avg:  7m 17s | Max:  7m 17s
  🟩 MSVC               Pass: 100%/4   | Total: 52m 53s | Avg: 13m 13s | Max: 14m 51s | Hits:  99%/3064  
  🟩 NVHPC              Pass: 100%/2   | Total: 18m 47s | Avg:  9m 23s | Max:  9m 45s
🟩 gpu
  🟩 v100               Pass: 100%/45  | Total:  6h 35m | Avg:  8m 47s | Max: 41m 33s | Hits:  99%/3064  
🟩 jobs
  🟩 Build              Pass: 100%/39  | Total:  4h 03m | Avg:  6m 14s | Max: 14m 51s | Hits:  99%/3064  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 16m 48s | Avg: 16m 48s | Max: 16m 48s
  🟩 GraphCapture       Pass: 100%/1   | Total: 20m 59s | Avg: 20m 59s | Max: 20m 59s
  🟩 HostLaunch         Pass: 100%/2   | Total: 42m 23s | Avg: 21m 11s | Max: 22m 09s
  🟩 TestGPU            Pass: 100%/2   | Total:  1h 11m | Avg: 35m 53s | Max: 41m 33s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 16s | Avg:  4m 16s | Max:  4m 16s
🟩 std
  🟩 11                 Pass: 100%/5   | Total: 23m 10s | Avg:  4m 38s | Max:  5m 53s
  🟩 14                 Pass: 100%/4   | Total: 31m 01s | Avg:  7m 45s | Max: 14m 51s | Hits:  99%/766   
  🟩 17                 Pass: 100%/12  | Total:  1h 22m | Avg:  6m 52s | Max: 12m 30s | Hits:  99%/1532  
  🟩 20                 Pass: 100%/24  | Total:  4h 18m | Avg: 10m 47s | Max: 41m 33s | Hits:  99%/766

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 34s | Avg: 5m 17s | Max: 8m 30s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  8m 30s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  8m 30s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  8m 30s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  8m 30s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  8m 30s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  8m 30s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 10m 34s | Avg:  5m 17s | Max:  8m 30s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 04s | Avg:  2m 04s | Max:  2m 04s
  🟩 Test               Pass: 100%/1   | Total:  8m 30s | Avg:  8m 30s | Max:  8m 30s

  • 🟩 python: Pass: 100%/1 | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 30m 44s | Avg: 30m 44s | Max: 30m 44s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 94)
# Runner
70 linux-amd64-cpu16
11 linux-amd64-gpu-v100-latest-1
9 windows-amd64-cpu16
4 linux-arm64-cpu16

@miscco miscco merged commit b116230 into NVIDIA:main Dec 11, 2024
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

@miscco miscco miscco approved these changes

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler was automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caugonnet @bernhardmgruber @miscco