make the `_CCCL_REQUIRES_EXPR` macro more robust #3164

ericniebler · 2024-12-13T20:24:28Z

Description

_CCCL_REQUIRES_EXPR needs a unique identifier. currently it uses __LINE__ to make an identifier unique, but that can cause conflicts. this PR changes it to use __COUNTER__ instead when available.

it also adds _CCCL_COUNTER() to __cccl/preprocessor.h. when __COUNTER__ is unavailable, it expands to __LINE__.

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

`_CCCL_REQUIRES_EXPR` needs a unique identifier. currently it uses `__LINE__` to make an identifier unique, but that can cause conflicts. this PR changes it to use `__COUNTER__` instead when available.

github-actions · 2024-12-13T22:40:11Z

🟩 CI finished in 1h 36m: Pass: 100%/168 | Total: 2d 03h | Avg: 18m 16s | Max: 1h 11m | Hits: 31%/22466

🟩 libcudacxx: Pass: 100%/48 | Total: 9h 06m | Avg: 11m 23s | Max: 38m 56s | Hits: 18%/9770

🟩 cpu
  🟩 amd64              Pass: 100%/46  | Total:  8h 59m | Avg: 11m 43s | Max: 38m 56s | Hits:  18%/9770  
  🟩 arm64              Pass: 100%/2   | Total:  7m 03s | Avg:  3m 31s | Max:  3m 39s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total: 49m 40s | Avg:  7m 05s | Max: 32m 08s | Hits:   9%/2228  
  🟩 12.5               Pass: 100%/2   | Total: 58m 58s | Avg: 29m 29s | Max: 30m 27s
  🟩 12.6               Pass: 100%/39  | Total:  7h 17m | Avg: 11m 13s | Max: 38m 56s | Hits:  20%/7542  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total:  1h 02m | Avg: 15m 32s | Max: 19m 13s
  🟩 nvcc11.1           Pass: 100%/7   | Total: 49m 40s | Avg:  7m 05s | Max: 32m 08s | Hits:   9%/2228  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 58m 58s | Avg: 29m 29s | Max: 30m 27s
  🟩 nvcc12.6           Pass: 100%/35  | Total:  6h 15m | Avg: 10m 44s | Max: 38m 56s | Hits:  20%/7542  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total:  1h 02m | Avg: 15m 32s | Max: 19m 13s
  🟩 nvcc               Pass: 100%/44  | Total:  8h 04m | Avg: 11m 00s | Max: 38m 56s | Hits:  18%/9770  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total: 14m 55s | Avg:  3m 43s | Max:  4m 33s
  🟩 Clang10            Pass: 100%/1   | Total:  5m 01s | Avg:  5m 01s | Max:  5m 01s
  🟩 Clang11            Pass: 100%/1   | Total:  4m 13s | Avg:  4m 13s | Max:  4m 13s
  🟩 Clang12            Pass: 100%/1   | Total:  4m 00s | Avg:  4m 00s | Max:  4m 00s
  🟩 Clang13            Pass: 100%/1   | Total:  4m 00s | Avg:  4m 00s | Max:  4m 00s
  🟩 Clang14            Pass: 100%/1   | Total:  4m 24s | Avg:  4m 24s | Max:  4m 24s
  🟩 Clang15            Pass: 100%/1   | Total:  4m 10s | Avg:  4m 10s | Max:  4m 10s
  🟩 Clang16            Pass: 100%/1   | Total:  4m 04s | Avg:  4m 04s | Max:  4m 04s
  🟩 Clang17            Pass: 100%/1   | Total:  4m 05s | Avg:  4m 05s | Max:  4m 05s
  🟩 Clang18            Pass: 100%/8   | Total:  1h 31m | Avg: 11m 25s | Max: 19m 13s
  🟩 GCC6               Pass: 100%/2   | Total:  5m 13s | Avg:  2m 36s | Max:  2m 49s
  🟩 GCC7               Pass: 100%/2   | Total:  6m 38s | Avg:  3m 19s | Max:  3m 34s
  🟩 GCC8               Pass: 100%/1   | Total:  3m 50s | Avg:  3m 50s | Max:  3m 50s
  🟩 GCC9               Pass: 100%/3   | Total:  9m 26s | Avg:  3m 08s | Max:  3m 37s
  🟩 GCC10              Pass: 100%/1   | Total:  3m 45s | Avg:  3m 45s | Max:  3m 45s
  🟩 GCC11              Pass: 100%/1   | Total:  4m 00s | Avg:  4m 00s | Max:  4m 00s
  🟩 GCC12              Pass: 100%/1   | Total:  4m 11s | Avg:  4m 11s | Max:  4m 11s
  🟩 GCC13              Pass: 100%/10  | Total:  2h 48m | Avg: 16m 49s | Max: 38m 56s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total:  5m 37s | Avg:  5m 37s | Max:  5m 37s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 32m 08s | Avg: 32m 08s | Max: 32m 08s | Hits:   9%/2228  
  🟩 MSVC14.29          Pass: 100%/1   | Total: 35m 25s | Avg: 35m 25s | Max: 35m 25s | Hits:  22%/2465  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 08m | Avg: 34m 27s | Max: 36m 50s | Hits:  20%/5077  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 58m 58s | Avg: 29m 29s | Max: 30m 27s
🟩 cxx_family
  🟩 Clang              Pass: 100%/20  | Total:  2h 20m | Avg:  7m 00s | Max: 19m 13s
  🟩 GCC                Pass: 100%/21  | Total:  3h 25m | Avg:  9m 46s | Max: 38m 56s
  🟩 Intel              Pass: 100%/1   | Total:  5m 37s | Avg:  5m 37s | Max:  5m 37s
  🟩 MSVC               Pass: 100%/4   | Total:  2h 16m | Avg: 34m 07s | Max: 36m 50s | Hits:  18%/9770  
  🟩 NVHPC              Pass: 100%/2   | Total: 58m 58s | Avg: 29m 29s | Max: 30m 27s
🟩 gpu
  🟩 v100               Pass: 100%/48  | Total:  9h 06m | Avg: 11m 23s | Max: 38m 56s | Hits:  18%/9770  
🟩 jobs
  🟩 Build              Pass: 100%/41  | Total:  6h 16m | Avg:  9m 10s | Max: 36m 50s | Hits:  18%/9770  
  🟩 NVRTC              Pass: 100%/4   | Total:  2h 11m | Avg: 32m 56s | Max: 38m 56s
  🟩 Test               Pass: 100%/2   | Total: 36m 12s | Avg: 18m 06s | Max: 18m 53s
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  2m 19s | Avg:  2m 19s | Max:  2m 19s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total: 13m 44s | Avg: 13m 44s | Max: 13m 44s
  🟩 90a                Pass: 100%/2   | Total: 15m 24s | Avg:  7m 42s | Max: 11m 47s
🟩 std
  🟩 11                 Pass: 100%/6   | Total: 49m 23s | Avg:  8m 13s | Max: 34m 30s
  🟩 14                 Pass: 100%/5   | Total:  1h 22m | Avg: 16m 24s | Max: 38m 56s | Hits:   9%/2228  
  🟩 17                 Pass: 100%/13  | Total:  2h 46m | Avg: 12m 49s | Max: 35m 25s | Hits:  21%/4930  
  🟩 20                 Pass: 100%/23  | Total:  4h 06m | Avg: 10m 42s | Max: 38m 10s | Hits:  19%/2612

🟩 thrust: Pass: 100%/46 | Total: 11h 46m | Avg: 15m 21s | Max: 1h 11m | Hits: 42%/9260

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 49s | Avg:  8m 54s | Max: 11m 34s
🟩 cpu
  🟩 amd64              Pass: 100%/44  | Total: 11h 37m | Avg: 15m 50s | Max:  1h 11m | Hits:  42%/9260  
  🟩 arm64              Pass: 100%/2   | Total:  9m 34s | Avg:  4m 47s | Max:  5m 06s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total:  1h 28m | Avg: 12m 40s | Max:  1h 04m | Hits:  46%/1852  
  🟩 12.5               Pass: 100%/2   | Total:  1h 58m | Avg: 59m 23s | Max: 59m 26s
  🟩 12.6               Pass: 100%/37  | Total:  8h 19m | Avg: 13m 29s | Max:  1h 11m | Hits:  40%/7408  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 56s | Avg:  4m 58s | Max:  5m 00s
  🟩 nvcc11.1           Pass: 100%/7   | Total:  1h 28m | Avg: 12m 40s | Max:  1h 04m | Hits:  46%/1852  
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 58m | Avg: 59m 23s | Max: 59m 26s
  🟩 nvcc12.6           Pass: 100%/35  | Total:  8h 09m | Avg: 13m 58s | Max:  1h 11m | Hits:  40%/7408  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 56s | Avg:  4m 58s | Max:  5m 00s
  🟩 nvcc               Pass: 100%/44  | Total: 11h 36m | Avg: 15m 50s | Max:  1h 11m | Hits:  42%/9260  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total: 20m 27s | Avg:  5m 06s | Max:  6m 34s
  🟩 Clang10            Pass: 100%/1   | Total:  7m 05s | Avg:  7m 05s | Max:  7m 05s
  🟩 Clang11            Pass: 100%/1   | Total:  4m 59s | Avg:  4m 59s | Max:  4m 59s
  🟩 Clang12            Pass: 100%/1   | Total:  5m 01s | Avg:  5m 01s | Max:  5m 01s
  🟩 Clang13            Pass: 100%/1   | Total:  5m 26s | Avg:  5m 26s | Max:  5m 26s
  🟩 Clang14            Pass: 100%/1   | Total:  5m 02s | Avg:  5m 02s | Max:  5m 02s
  🟩 Clang15            Pass: 100%/1   | Total:  5m 51s | Avg:  5m 51s | Max:  5m 51s
  🟩 Clang16            Pass: 100%/1   | Total:  5m 13s | Avg:  5m 13s | Max:  5m 13s
  🟩 Clang17            Pass: 100%/1   | Total:  5m 35s | Avg:  5m 35s | Max:  5m 35s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 03m | Avg:  9m 01s | Max: 30m 19s
  🟩 GCC6               Pass: 100%/2   | Total:  7m 46s | Avg:  3m 53s | Max:  4m 12s
  🟩 GCC7               Pass: 100%/2   | Total:  9m 32s | Avg:  4m 46s | Max:  5m 03s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 39s | Avg:  5m 39s | Max:  5m 39s
  🟩 GCC9               Pass: 100%/3   | Total: 13m 30s | Avg:  4m 30s | Max:  5m 29s
  🟩 GCC10              Pass: 100%/1   | Total:  6m 03s | Avg:  6m 03s | Max:  6m 03s
  🟩 GCC11              Pass: 100%/1   | Total:  6m 05s | Avg:  6m 05s | Max:  6m 05s
  🟩 GCC12              Pass: 100%/1   | Total:  5m 54s | Avg:  5m 54s | Max:  5m 54s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 25m | Avg: 10m 37s | Max: 37m 00s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total: 25m 02s | Avg: 25m 02s | Max: 25m 02s
  🟩 MSVC14.16          Pass: 100%/1   | Total:  1h 04m | Avg:  1h 04m | Max:  1h 04m | Hits:  46%/1852  
  🟩 MSVC14.29          Pass: 100%/1   | Total:  1h 11m | Avg:  1h 11m | Max:  1h 11m | Hits:  14%/1852  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 39m | Avg: 53m 10s | Max:  1h 09m | Hits:  49%/5556  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 58m | Avg: 59m 23s | Max: 59m 26s
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total:  2h 07m | Avg:  6m 43s | Max: 30m 19s
  🟩 GCC                Pass: 100%/19  | Total:  2h 19m | Avg:  7m 20s | Max: 37m 00s
  🟩 Intel              Pass: 100%/1   | Total: 25m 02s | Avg: 25m 02s | Max: 25m 02s
  🟩 MSVC               Pass: 100%/5   | Total:  4h 55m | Avg: 59m 05s | Max:  1h 11m | Hits:  42%/9260  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 58m | Avg: 59m 23s | Max: 59m 26s
🟩 gpu
  🟩 v100               Pass: 100%/46  | Total: 11h 46m | Avg: 15m 21s | Max:  1h 11m | Hits:  42%/9260  
🟩 jobs
  🟩 Build              Pass: 100%/40  | Total:  9h 49m | Avg: 14m 43s | Max:  1h 11m | Hits:  27%/7408  
  🟩 TestCPU            Pass: 100%/3   | Total: 38m 28s | Avg: 12m 49s | Max: 23m 01s | Hits:  99%/1852  
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 18m | Avg: 26m 17s | Max: 37m 00s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 33s | Avg:  4m 33s | Max:  4m 33s
🟩 std
  🟩 11                 Pass: 100%/5   | Total: 21m 07s | Avg:  4m 13s | Max:  5m 19s
  🟩 14                 Pass: 100%/4   | Total:  1h 20m | Avg: 20m 02s | Max:  1h 04m | Hits:  46%/1852  
  🟩 17                 Pass: 100%/12  | Total:  4h 26m | Avg: 22m 14s | Max:  1h 11m | Hits:  28%/3704  
  🟩 20                 Pass: 100%/23  | Total:  5h 20m | Avg: 13m 56s | Max:  1h 09m | Hits:  53%/3704

🟩 cub: Pass: 100%/45 | Total: 1d 03h | Avg: 36m 16s | Max: 1h 02m | Hits: 35%/3124

🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  1d 01h | Avg: 35m 51s | Max:  1h 02m | Hits:  35%/3124  
  🟩 arm64              Pass: 100%/2   | Total:  1h 30m | Avg: 45m 02s | Max: 46m 05s
🟩 ctk
  🟩 11.1               Pass: 100%/7   | Total:  4h 01m | Avg: 34m 28s | Max: 58m 17s | Hits:  10%/781   
  🟩 12.5               Pass: 100%/2   | Total:  1h 52m | Avg: 56m 15s | Max: 57m 07s
  🟩 12.6               Pass: 100%/36  | Total: 21h 18m | Avg: 35m 30s | Max:  1h 02m | Hits:  43%/2343  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  1h 46m | Avg: 53m 01s | Max: 55m 17s
  🟩 nvcc11.1           Pass: 100%/7   | Total:  4h 01m | Avg: 34m 28s | Max: 58m 17s | Hits:  10%/781   
  🟩 nvcc12.5           Pass: 100%/2   | Total:  1h 52m | Avg: 56m 15s | Max: 57m 07s
  🟩 nvcc12.6           Pass: 100%/34  | Total: 19h 32m | Avg: 34m 28s | Max:  1h 02m | Hits:  43%/2343  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  1h 46m | Avg: 53m 01s | Max: 55m 17s
  🟩 nvcc               Pass: 100%/43  | Total:  1d 01h | Avg: 35m 29s | Max:  1h 02m | Hits:  35%/3124  
🟩 cxx
  🟩 Clang9             Pass: 100%/4   | Total:  2h 13m | Avg: 33m 19s | Max: 37m 16s
  🟩 Clang10            Pass: 100%/1   | Total: 34m 07s | Avg: 34m 07s | Max: 34m 07s
  🟩 Clang11            Pass: 100%/1   | Total: 33m 28s | Avg: 33m 28s | Max: 33m 28s
  🟩 Clang12            Pass: 100%/1   | Total: 35m 23s | Avg: 35m 23s | Max: 35m 23s
  🟩 Clang13            Pass: 100%/1   | Total: 36m 19s | Avg: 36m 19s | Max: 36m 19s
  🟩 Clang14            Pass: 100%/1   | Total: 34m 12s | Avg: 34m 12s | Max: 34m 12s
  🟩 Clang15            Pass: 100%/1   | Total: 33m 56s | Avg: 33m 56s | Max: 33m 56s
  🟩 Clang16            Pass: 100%/1   | Total: 34m 31s | Avg: 34m 31s | Max: 34m 31s
  🟩 Clang17            Pass: 100%/1   | Total: 34m 51s | Avg: 34m 51s | Max: 34m 51s
  🟩 Clang18            Pass: 100%/7   | Total:  4h 26m | Avg: 38m 05s | Max: 55m 17s
  🟩 GCC6               Pass: 100%/2   | Total:  1h 01m | Avg: 30m 49s | Max: 31m 50s
  🟩 GCC7               Pass: 100%/2   | Total:  1h 07m | Avg: 33m 31s | Max: 33m 34s
  🟩 GCC8               Pass: 100%/1   | Total: 35m 39s | Avg: 35m 39s | Max: 35m 39s
  🟩 GCC9               Pass: 100%/3   | Total:  1h 32m | Avg: 30m 46s | Max: 33m 31s
  🟩 GCC10              Pass: 100%/1   | Total: 33m 34s | Avg: 33m 34s | Max: 33m 34s
  🟩 GCC11              Pass: 100%/1   | Total: 34m 03s | Avg: 34m 03s | Max: 34m 03s
  🟩 GCC12              Pass: 100%/1   | Total: 35m 14s | Avg: 35m 14s | Max: 35m 14s
  🟩 GCC13              Pass: 100%/8   | Total:  3h 23m | Avg: 25m 28s | Max: 46m 05s
  🟩 Intel2023.2.0      Pass: 100%/1   | Total: 39m 16s | Avg: 39m 16s | Max: 39m 16s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 58m 17s | Avg: 58m 17s | Max: 58m 17s | Hits:  10%/781   
  🟩 MSVC14.29          Pass: 100%/1   | Total: 59m 35s | Avg: 59m 35s | Max: 59m 35s | Hits:  56%/781   
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 02m | Avg:  1h 01m | Max:  1h 02m | Hits:  37%/1562  
  🟩 NVHPC24.7          Pass: 100%/2   | Total:  1h 52m | Avg: 56m 15s | Max: 57m 07s
🟩 cxx_family
  🟩 Clang              Pass: 100%/19  | Total: 11h 16m | Avg: 35m 36s | Max: 55m 17s
  🟩 GCC                Pass: 100%/19  | Total:  9h 23m | Avg: 29m 38s | Max: 46m 05s
  🟩 Intel              Pass: 100%/1   | Total: 39m 16s | Avg: 39m 16s | Max: 39m 16s
  🟩 MSVC               Pass: 100%/4   | Total:  4h 00m | Avg:  1h 00m | Max:  1h 02m | Hits:  35%/3124  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 52m | Avg: 56m 15s | Max: 57m 07s
🟩 gpu
  🟩 v100               Pass: 100%/45  | Total:  1d 03h | Avg: 36m 16s | Max:  1h 02m | Hits:  35%/3124  
🟩 jobs
  🟩 Build              Pass: 100%/39  | Total:  1d 01h | Avg: 38m 32s | Max:  1h 02m | Hits:  35%/3124  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 19m 14s | Avg: 19m 14s | Max: 19m 14s
  🟩 GraphCapture       Pass: 100%/1   | Total: 17m 37s | Avg: 17m 37s | Max: 17m 37s
  🟩 HostLaunch         Pass: 100%/2   | Total: 41m 59s | Avg: 20m 59s | Max: 21m 38s
  🟩 TestGPU            Pass: 100%/2   | Total: 50m 10s | Avg: 25m 05s | Max: 26m 49s
🟩 sm
  🟩 90a                Pass: 100%/1   | Total:  4m 37s | Avg:  4m 37s | Max:  4m 37s
🟩 std
  🟩 11                 Pass: 100%/5   | Total:  2h 38m | Avg: 31m 43s | Max: 33m 29s
  🟩 14                 Pass: 100%/4   | Total:  2h 38m | Avg: 39m 43s | Max: 58m 17s | Hits:  10%/781   
  🟩 17                 Pass: 100%/12  | Total:  8h 25m | Avg: 42m 06s | Max:  1h 00m | Hits:  45%/1562  
  🟩 20                 Pass: 100%/24  | Total: 13h 29m | Avg: 33m 43s | Max:  1h 02m | Hits:  39%/781

🟩 cudax: Pass: 100%/26 | Total: 2h 23m | Avg: 5m 30s | Max: 30m 02s | Hits: 92%/312

🟩 cpu
  🟩 amd64              Pass: 100%/22  | Total:  2h 10m | Avg:  5m 56s | Max: 30m 02s | Hits:  92%/312   
  🟩 arm64              Pass: 100%/4   | Total: 12m 14s | Avg:  3m 03s | Max:  3m 37s
🟩 ctk
  🟩 12.0               Pass: 100%/3   | Total: 15m 18s | Avg:  5m 06s | Max:  8m 25s | Hits:  92%/156   
  🟩 12.5               Pass: 100%/2   | Total: 13m 05s | Avg:  6m 32s | Max:  7m 15s
  🟩 12.6               Pass: 100%/21  | Total:  1h 54m | Avg:  5m 27s | Max: 30m 02s | Hits:  92%/156   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/3   | Total: 15m 18s | Avg:  5m 06s | Max:  8m 25s | Hits:  92%/156   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 13m 05s | Avg:  6m 32s | Max:  7m 15s
  🟩 nvcc12.6           Pass: 100%/21  | Total:  1h 54m | Avg:  5m 27s | Max: 30m 02s | Hits:  92%/156   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/26  | Total:  2h 23m | Avg:  5m 30s | Max: 30m 02s | Hits:  92%/312   
🟩 cxx
  🟩 Clang9             Pass: 100%/1   | Total:  3m 32s | Avg:  3m 32s | Max:  3m 32s
  🟩 Clang10            Pass: 100%/1   | Total:  3m 44s | Avg:  3m 44s | Max:  3m 44s
  🟩 Clang11            Pass: 100%/1   | Total:  2m 58s | Avg:  2m 58s | Max:  2m 58s
  🟩 Clang12            Pass: 100%/1   | Total:  3m 24s | Avg:  3m 24s | Max:  3m 24s
  🟩 Clang13            Pass: 100%/1   | Total:  3m 06s | Avg:  3m 06s | Max:  3m 06s
  🟩 Clang14            Pass: 100%/1   | Total:  3m 20s | Avg:  3m 20s | Max:  3m 20s
  🟩 Clang15            Pass: 100%/1   | Total:  3m 20s | Avg:  3m 20s | Max:  3m 20s
  🟩 Clang16            Pass: 100%/1   | Total:  3m 09s | Avg:  3m 09s | Max:  3m 09s
  🟩 Clang17            Pass: 100%/1   | Total:  3m 15s | Avg:  3m 15s | Max:  3m 15s
  🟩 Clang18            Pass: 100%/4   | Total: 39m 30s | Avg:  9m 52s | Max: 30m 02s
  🟩 GCC9               Pass: 100%/1   | Total:  3m 21s | Avg:  3m 21s | Max:  3m 21s
  🟩 GCC10              Pass: 100%/1   | Total:  2m 53s | Avg:  2m 53s | Max:  2m 53s
  🟩 GCC11              Pass: 100%/1   | Total:  3m 23s | Avg:  3m 23s | Max:  3m 23s
  🟩 GCC12              Pass: 100%/2   | Total: 21m 12s | Avg: 10m 36s | Max: 18m 05s
  🟩 GCC13              Pass: 100%/4   | Total: 12m 49s | Avg:  3m 12s | Max:  3m 37s
  🟩 MSVC14.36          Pass: 100%/1   | Total:  8m 25s | Avg:  8m 25s | Max:  8m 25s | Hits:  92%/156   
  🟩 MSVC14.39          Pass: 100%/1   | Total:  8m 34s | Avg:  8m 34s | Max:  8m 34s | Hits:  92%/156   
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 13m 05s | Avg:  6m 32s | Max:  7m 15s
🟩 cxx_family
  🟩 Clang              Pass: 100%/13  | Total:  1h 09m | Avg:  5m 19s | Max: 30m 02s
  🟩 GCC                Pass: 100%/9   | Total: 43m 38s | Avg:  4m 50s | Max: 18m 05s
  🟩 MSVC               Pass: 100%/2   | Total: 16m 59s | Avg:  8m 29s | Max:  8m 34s | Hits:  92%/312   
  🟩 NVHPC              Pass: 100%/2   | Total: 13m 05s | Avg:  6m 32s | Max:  7m 15s
🟩 gpu
  🟩 v100               Pass: 100%/26  | Total:  2h 23m | Avg:  5m 30s | Max: 30m 02s | Hits:  92%/312   
🟩 jobs
  🟩 Build              Pass: 100%/24  | Total:  1h 34m | Avg:  3m 57s | Max:  8m 34s | Hits:  92%/312   
  🟩 Test               Pass: 100%/2   | Total: 48m 07s | Avg: 24m 03s | Max: 30m 02s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  3m 34s | Avg:  3m 34s | Max:  3m 34s
  🟩 90a                Pass: 100%/1   | Total:  2m 59s | Avg:  2m 59s | Max:  2m 59s
🟩 std
  🟩 17                 Pass: 100%/6   | Total: 24m 42s | Avg:  4m 07s | Max:  7m 15s
  🟩 20                 Pass: 100%/20  | Total:  1h 58m | Avg:  5m 54s | Max: 30m 02s | Hits:  92%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 11m 34s | Avg: 5m 47s | Max: 9m 39s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 11m 34s | Avg:  5m 47s | Max:  9m 39s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 11m 34s | Avg:  5m 47s | Max:  9m 39s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 11m 34s | Avg:  5m 47s | Max:  9m 39s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 11m 34s | Avg:  5m 47s | Max:  9m 39s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 11m 34s | Avg:  5m 47s | Max:  9m 39s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 11m 34s | Avg:  5m 47s | Max:  9m 39s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 11m 34s | Avg:  5m 47s | Max:  9m 39s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  1m 55s | Avg:  1m 55s | Max:  1m 55s
  🟩 Test               Pass: 100%/1   | Total:  9m 39s | Avg:  9m 39s | Max:  9m 39s

🟩 python: Pass: 100%/1 | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
+/-	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 168)

#	Runner
124	`linux-amd64-cpu16`
19	`linux-amd64-gpu-v100-latest-1`
15	`windows-amd64-cpu16`
10	`linux-arm64-cpu16`

make the _CCCL_REQUIRES_EXPR macro more robust

ec5078c

`_CCCL_REQUIRES_EXPR` needs a unique identifier. currently it uses `__LINE__` to make an identifier unique, but that can cause conflicts. this PR changes it to use `__COUNTER__` instead when available.

ericniebler requested review from a team as code owners December 13, 2024 20:24

ericniebler requested review from griwes and fbusato December 13, 2024 20:24

ericniebler added 2 commits December 13, 2024 20:42

fix thinko

5a8988f

another thinko. bad brain.

a4c7563

miscco approved these changes Dec 13, 2024

View reviewed changes

ericniebler merged commit e13efb7 into NVIDIA:main Dec 13, 2024
183 checks passed

ericniebler deleted the fix-cccl-requires-expr-macro branch December 13, 2024 23:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make the `_CCCL_REQUIRES_EXPR` macro more robust #3164

make the `_CCCL_REQUIRES_EXPR` macro more robust #3164

ericniebler commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

🟩 libcudacxx: Pass: 100%/48 | Total: 9h 06m | Avg: 11m 23s | Max: 38m 56s | Hits: 18%/9770

🟩 thrust: Pass: 100%/46 | Total: 11h 46m | Avg: 15m 21s | Max: 1h 11m | Hits: 42%/9260

🟩 cub: Pass: 100%/45 | Total: 1d 03h | Avg: 36m 16s | Max: 1h 02m | Hits: 35%/3124

🟩 cudax: Pass: 100%/26 | Total: 2h 23m | Avg: 5m 30s | Max: 30m 02s | Hits: 92%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 11m 34s | Avg: 5m 47s | Max: 9m 39s

🟩 python: Pass: 100%/1 | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 168)

make the _CCCL_REQUIRES_EXPR macro more robust #3164

make the _CCCL_REQUIRES_EXPR macro more robust #3164

Conversation

ericniebler commented Dec 13, 2024

Description

Checklist

github-actions bot commented Dec 13, 2024

🟩 libcudacxx: Pass: 100%/48 | Total: 9h 06m | Avg: 11m 23s | Max: 38m 56s | Hits: 18%/9770

🟩 thrust: Pass: 100%/46 | Total: 11h 46m | Avg: 15m 21s | Max: 1h 11m | Hits: 42%/9260

🟩 cub: Pass: 100%/45 | Total: 1d 03h | Avg: 36m 16s | Max: 1h 02m | Hits: 35%/3124

🟩 cudax: Pass: 100%/26 | Total: 2h 23m | Avg: 5m 30s | Max: 30m 02s | Hits: 92%/312

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 11m 34s | Avg: 5m 47s | Max: 9m 39s

🟩 python: Pass: 100%/1 | Total: 29m 08s | Avg: 29m 08s | Max: 29m 08s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 168)

make the `_CCCL_REQUIRES_EXPR` macro more robust #3164

make the `_CCCL_REQUIRES_EXPR` macro more robust #3164