This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix some warning about usage of __host__ functions in __device__ code
#1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we cannot use `optional::value` on device, as that might throw if there is no value stored. However, in `emplace` we know that there must be a value stored, as we have just created it. Consequently, just return `this->_m_value`
Previously, we would use host `limits`, as it was not available at that time in libcu++. However, libcu++ has gained that support a long time ago so just use that.
|
run tests |
gevtushenko
approved these changes
Oct 10, 2022
jrhemstad
approved these changes
Oct 10, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
Fix some warning about usage of `__host__` functions in `__device__` code d641d63
github-actions bot
pushed a commit
to clayne/thrust
that referenced
this pull request
Oct 10, 2022
…g_3826028 Fix some warning about usage of `__host__` functions in `__device__` code d641d63
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal CI improved handling of warnings so we goth those two new warnings about
__host__functions in__device__code.Luckily those are easy to work around
P.S. yes there is a typo but 🧛