Scc 4417/format filters #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…talog into SCC-4417/format-filters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dgcohen
reviewed
Mar 4, 2025
src/types/searchTypes.ts
Outdated
| @@ -8,11 +8,11 @@ type SubjectLiteral = string | |||
| type ContributorLiteral = string | |||
| type CreatorLiteral = string | |||
| type Issuance = string | |||
| type MaterialTypeFilter = string | |||
| type formatFilter = string | |||
There was a problem hiding this comment.
Should this be capitalized since it's a type?
dgcohen
reviewed
Mar 4, 2025
| @@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Updated | |||
|
|
|||
| - Send new searches back to home, not /search [SCC-4487](https://newyorkpubliclibrary.atlassian.net/browse/SCC-4487) | |||
| - Removed legacy barcode hotfix (SCC-4474) | |||
There was a problem hiding this comment.
This line doesn't need to be removed
dgcohen
requested changes
Mar 4, 2025
dgcohen
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
How has this been tested?
Running searches and using available formats to filter results.
Accessibility concerns or updates
Checklist: