Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitch interval decoding: discarding notes outside the tokenizer pitch range #149

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Feb 23, 2024


📚 Documentation preview 📚: https://miditok--149.org.readthedocs.build/en/149/

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.09%. Comparing base (e793368) to head (2121a09).

Files Patch % Lines
miditok/tokenizations/midi_like.py 80.00% 1 Missing ⚠️
miditok/tokenizations/mmm.py 80.00% 1 Missing ⚠️
miditok/tokenizations/remi.py 80.00% 1 Missing ⚠️
miditok/tokenizations/tsd.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   91.23%   91.09%   -0.15%     
==========================================
  Files          33       33              
  Lines        4985     4984       -1     
==========================================
- Hits         4548     4540       -8     
- Misses        437      444       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz merged commit 18a6b3a into main Feb 24, 2024
13 checks passed
@Natooz Natooz deleted the pitch-interval-oor branch February 24, 2024 06:24
Natooz added a commit that referenced this pull request Mar 18, 2024
… range (#149)

* pitch interval decoding: discarding notes outside the tokenizer pitch range

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant