Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitrack ProgramChange #72

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Multitrack ProgramChange #72

merged 4 commits into from
Sep 7, 2023

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Sep 5, 2023

Following #71, this PR adds the option (config.program_changes) to use Program tokens similarly to the way the MIDI Program Change messages occur.

The option only works for TSD, REMI and MIDILike as multi-voc tokenizers will gather the Program information with the note tokens, program changes would break Structured's recurrent token type succession, and MMM already separate the tracks within the token sequence.

Still a few things to check, and enforce the multitrack tests

@Natooz Natooz added the enhancement New feature or request label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 85.25% and project coverage change: +0.45% 🎉

Comparison is base (a1543cd) 89.21% compared to head (1c92383) 89.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   89.21%   89.67%   +0.45%     
==========================================
  Files          31       31              
  Lines        4201     4260      +59     
==========================================
+ Hits         3748     3820      +72     
+ Misses        453      440      -13     
Files Changed Coverage Δ
setup.py 0.00% <ø> (ø)
miditok/classes.py 84.50% <42.85%> (-3.96%) ⬇️
tests/test_one_track.py 78.33% <66.66%> (+6.16%) ⬆️
tests/tests_utils.py 77.35% <68.08%> (-4.06%) ⬇️
miditok/tokenizations/midi_like.py 93.75% <85.71%> (ø)
tests/test_multitrack.py 83.60% <88.23%> (+13.72%) ⬆️
miditok/midi_tokenizer.py 89.06% <97.77%> (+0.97%) ⬆️
miditok/constants.py 100.00% <100.00%> (ø)
miditok/tokenizations/cp_word.py 93.43% <100.00%> (+0.41%) ⬆️
miditok/tokenizations/mmm.py 92.34% <100.00%> (+0.03%) ⬆️
... and 7 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz marked this pull request as ready for review September 7, 2023 08:15
@Natooz Natooz merged commit 388433d into main Sep 7, 2023
@Natooz Natooz deleted the multitrack-programchange branch September 7, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant