Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bug when learning bpe without special tokens #92

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Oct 31, 2023

Fixing #90

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (42d4cdf) 90.34% compared to head (db36346) 90.35%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   90.34%   90.35%   +0.01%     
==========================================
  Files          33       33              
  Lines        4577     4584       +7     
==========================================
+ Hits         4135     4142       +7     
  Misses        442      442              
Files Coverage Δ
miditok/midi_tokenizer.py 90.55% <100.00%> (+0.01%) ⬆️
setup.py 0.00% <ø> (ø)
tests/test_bpe.py 90.21% <100.00%> (+0.10%) ⬆️
tests/test_one_track.py 78.87% <100.00%> (-0.58%) ⬇️
tests/tests_utils.py 77.57% <100.00%> (+0.55%) ⬆️
tests/test_methods.py 94.11% <96.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Natooz pushed a commit that referenced this pull request Oct 31, 2023
(tests fail due to miditoolkit update, temp fix in #92)
Natooz pushed a commit that referenced this pull request Oct 31, 2023
(tests fail due to miditoolkit update, temp fix in #92)

* fix typos in miditok/midi_tokenizer.py

* fix typos in miditok/tokenizations/midi_like.py

* fix typos in miditok/tokenizations/structured.py

* fix typos in miditok/utils/utils.py
@Natooz Natooz merged commit ea1fecb into main Oct 31, 2023
@Natooz Natooz deleted the bpe-learn-without-special-tokens branch October 31, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant