Shiboken2 postmerge fixes in Engine #704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
This is a series of fixes after #697 was committed.
After the merge the enums of the Engine typesystem were placed in
NatronEngine
instead ofNatronEngine.Natron
, change which breaks scripts that used said enums. This PR amends the regression.This change also makes the hidden
set
methods inInt2DParam
andInt3DParam
private so they are not called where it's not supposed to be.And lastly the
Engine.pro
was modified to build with the Shiboken2 binding, which they'll reside inEngine/NatronEngine5
.Show a few screenshots (if this is a visual change)
N/A.
Have you tested your changes (if applicable)? If so, how?
Started
Natron
with thisinit.py
to assert that the enum was in the correct place.Tried with
natron-python
but the thing turned out to be disobedient.Futher details of this pull request
N/A.