Cap InnerBuffer::global_ubo size #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of glow::MAX_UNIFORM_BLOCK_SIZE can be arbitrarily large. For instance on Firefox on Linux with AMD GPUs tends to generate quite large values: 2**29 on RX 550, and 2**31 on RX 7600 XT, which will result in this function trying to create a 0.5 GB and a 2 GB buffer respectively. Creating buffers this large will either cause a quick OOM, or at least make the application unusably slow. This commit caps the returned size to 2**16, which is the value returned by Chromium in the same combination as above and results in this function creating 64 kB buffers.
metiulekm
force-pushed
the
amd_firefox_fix
branch
from
3ad2b23 to
5e519f5
Compare
|
Fixes #332. Finally got time to figure this out 😀 Tested this by running the bunnymark example on WASM/FF/Linux on both mentioned GPUs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of glow::MAX_UNIFORM_BLOCK_SIZE can be arbitrarily large. For instance on Firefox on Linux with AMD GPUs tends to generate quite large values: 2**29 on RX 550, and 2**31 on RX 7600 XT, which will result in this function trying to create a 0.5 GB and a 2 GB buffer respectively. Creating buffers this large will either cause a quick OOM, or at least make the application unusably slow.
This commit caps the returned size to 2**16, which is the value returned by Chromium in the same combination as above and results in this function creating 64 kB buffers.