Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes network bugs and adjusts program access #1053

Merged
merged 4 commits into from
Dec 22, 2020

Conversation

NataKilar
Copy link
Contributor

@NataKilar NataKilar commented Dec 19, 2020

Fixes a few bugs with networks and their related machinery, and adds an option for grant based program access

  • Fixes mainframes going invisible after opening their panel once
  • Fixes Network Locks not having their UI properly updated.
  • Changes how the transfer files backend works. Now it by default transfers the file with an option for cloning the file instead. Beforehand it used store_file to add the datum to the file list of whatever was being copied to, without removing itself from the former location, which resulted in every program downloaded from a mainframe being one instance. This lead to issues like Intranet Relay Chat Client is broken #1037, which is now fixed.
  • Fixes a bug where running a program without proper access would break the computer until it was restarted.
  • Added an option for program access to be determined by grants through the access controller. If/when full replacement of the access system with grants occurs, this should probably be reworked., but it works for now.

@NataKilar
Copy link
Contributor Author

NataKilar commented Dec 19, 2020

Adjusted program access/grants to use the normal empty list paradigm. Also went back and adjusted programs to use lists for their required_access var, and cleaned up a couple oddities (Command and Communications and Deck Management) programs who used unique access checks that could easily be replaced.

Copy link
Collaborator

@afterthought2 afterthought2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: the report access stuff should really be converted to the main system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants