Locking Savon to < 2.13 to prevent an error making queries #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avanrielly great! Going to merge, but can you submit another PR with a changelog entry? |
|
@iloveitaly Sorry, I did not even realize this was part of the process. I have made a follow-up PR here |
|
We may want to revert this (and #560) as the underlying issue in Savon was fixed and released as v2.13.1, and I confirmed the new version works correctly for me: v2.13.0 will continue to be broken, but restricting anyone from using the newer v2.13.1 (or future versions) doesn't seem ideal. |
|
@cgunther great idea! I think we can ban specific versions using |
cgunther
added a commit
to cgunther/netsuite
that referenced
this pull request
Sep 7, 2022
This version of Savon mistakenly prefixed the default namespace of `xmlns`, resulting in a namespace of `xmlns:xmlns`, which caused NetSuite to error on requests. v2.13.1 fixed this issue to skip prefixing the default namespace. This is a continuation of NetSweet#558, which avoided v2.13.0 and anything greater. Bug: savonrb/savon#943 (comment) Fix: savonrb/savon#977
cgunther
added a commit
to cgunther/netsuite
that referenced
this pull request
Sep 7, 2022
This version of Savon mistakenly prefixed the default namespace of `xmlns`, resulting in a namespace of `xmlns:xmlns`, which caused NetSuite to error on requests. v2.13.1 fixed this issue to skip prefixing the default namespace. This is a continuation of NetSweet#558, which avoided v2.13.0 and anything greater. Bug: savonrb/savon#943 (comment) Fix: savonrb/savon#977
iloveitaly
pushed a commit
that referenced
this pull request
Sep 7, 2022
…563) * Avoid Savon version `2.13.0` to prevent generating invalid envelopes This version of Savon mistakenly prefixed the default namespace of `xmlns`, resulting in a namespace of `xmlns:xmlns`, which caused NetSuite to error on requests. v2.13.1 fixed this issue to skip prefixing the default namespace. This is a continuation of #558, which avoided v2.13.0 and anything greater. Bug: savonrb/savon#943 (comment) Fix: savonrb/savon#977 * Use RC of mail gem in CI for Ruby 3.1 support Savon v2.13 adds a dependency on mail, which has an implicit dependency on net-smtp. Ruby 3.1 removed net-smtp as a default gem. mail v2.8.0.rc1 is the first to make that dependency explicit to support Ruby 3.1. This at least gets CI passing, but may not help end-users on Ruby 3.1. If they previously had a dependency on mail (ie. through Rails), there's probably already an explicit dependency in their app on net-smtp to get it working on Ruby 3.1. If they have no dependency on mail previously, this will likely error as they go to require this gem, which requires savon, which requires mail, which requires net-smtp, but Ruby can't find it. It doesn't seem right to add net-smtp (or an RC of mail) to this gem's gemspec dependencies, given we don't directly use either library. Ultimately it's about the latest stable release of mail being incompatible with Ruby 3.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a request with the NetSuite gem and Savon 2.13.0 caused the following error:
Therefore, this PR locks the Savon gem to the last versions that work.
If I had to guess at the PR that caused the issue, I would suggest it is this one.