Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display offset field as int for starknet_getCompiledCasm endpoint #2456

Closed
wants to merge 1 commit into from

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 11, 2025

Solves issue #2393

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 73.35%. Comparing base (81bd135) to head (01d0a7c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v8/compiled_casm.go 5.26% 18 Missing ⚠️

❌ Your patch status has failed because the patch coverage (5.26%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2456      +/-   ##
==========================================
- Coverage   73.36%   73.35%   -0.02%     
==========================================
  Files         142      142              
  Lines       17065    17200     +135     
==========================================
+ Hits        12520    12617      +97     
- Misses       3672     3699      +27     
- Partials      873      884      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojciechos
Copy link
Contributor

wojciechos commented Feb 11, 2025

Oh, sorry. I forgot to close the issue. This change was actually reverted in the latest rc-3 spec: starkware-libs/starknet-specs#275.

@hudem1 hudem1 closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants