-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Reuse rpcv6 juno_version handler for v7 and v8 #2471
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing the "errors" pkg should fix the tests and lint errors. Approving now to unblock this PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
==========================================
- Coverage 74.76% 74.71% -0.05%
==========================================
Files 139 139
Lines 16741 16734 -7
==========================================
- Hits 12516 12503 -13
- Misses 3389 3396 +7
+ Partials 836 835 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rpc pkg cleanup according to #2437
All 3 rpc versions'
juno_version
endpoint reference the same handler method in the "master" handler