Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Reuse rpcv6 juno_version handler for v7 and v8 #2471

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 13, 2025

rpc pkg cleanup according to #2437

All 3 rpc versions' juno_version endpoint reference the same handler method in the "master" handler

@hudem1 hudem1 mentioned this pull request Feb 13, 2025
23 tasks
@hudem1 hudem1 added RPC JSON RPC API Refactor labels Feb 13, 2025
Copy link
Contributor

@rianhughes rianhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing the "errors" pkg should fix the tests and lint errors. Approving now to unblock this PR

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.71%. Comparing base (80c2b5c) to head (a6de3ea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2471      +/-   ##
==========================================
- Coverage   74.76%   74.71%   -0.05%     
==========================================
  Files         139      139              
  Lines       16741    16734       -7     
==========================================
- Hits        12516    12503      -13     
- Misses       3389     3396       +7     
+ Partials      836      835       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hudem1 hudem1 requested a review from rodrigo-pino February 19, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor RPC JSON RPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants