Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blake2 optimization #3837

Merged
merged 26 commits into from
Feb 22, 2022
Merged

Blake2 optimization #3837

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
40070a2
Blake2f draft
marcindsobczak Feb 18, 2022
df2d38c
adapt Blake to specified number of rounds
marcindsobczak Feb 18, 2022
329aa4b
first working solution
marcindsobczak Feb 18, 2022
ab3e070
optimization
marcindsobczak Feb 18, 2022
d84527d
refactor
marcindsobczak Feb 18, 2022
50df30a
cleaning
marcindsobczak Feb 18, 2022
4fa2231
refactor&clean
marcindsobczak Feb 18, 2022
34dee1d
add Avx2
marcindsobczak Feb 18, 2022
df1137a
turn Avx2 off and use scalar
marcindsobczak Feb 18, 2022
3674a2b
check scalar solution performance
marcindsobczak Feb 18, 2022
761bac3
check avx2 solution performance
marcindsobczak Feb 18, 2022
3f79d32
add Sse41
marcindsobczak Feb 21, 2022
f6da3c4
refactor Avx2
marcindsobczak Feb 21, 2022
f4e0e2b
refactor scalar
marcindsobczak Feb 21, 2022
8077b45
refactor
marcindsobczak Feb 21, 2022
7287ddc
improve readability
marcindsobczak Feb 21, 2022
d3f35fe
Revert "refactor Avx2"
marcindsobczak Feb 21, 2022
8188509
avx2 optimization
marcindsobczak Feb 21, 2022
e169f4d
sse41 optimization
marcindsobczak Feb 21, 2022
fb7f0d2
scalar optimization
marcindsobczak Feb 21, 2022
b9ff854
uncomment test
marcindsobczak Feb 21, 2022
9997b26
add comment
marcindsobczak Feb 21, 2022
b889bb1
fix benchmark
marcindsobczak Feb 21, 2022
3381848
add tests for avx2, sse41 and scalar computations
marcindsobczak Feb 22, 2022
bc0efa3
refactor
marcindsobczak Feb 22, 2022
913cd0d
small optimization
marcindsobczak Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/Nethermind/Ethereum.Blockchain.Test/TimeConsumingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ public class TimeConsumingTests : GeneralStateTestBase
[TestCaseSource(nameof(LoadTests))]
public void Test(GeneralStateTest test)
{
if (test.Name.Contains("CALLBlake2f_MaxRound"))
{
return;
}

Assert.True(RunTest(test).Pass);
}

Expand Down
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Benchmark/Evm/Blake2Benchmark.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
using Nethermind.Core;
using Nethermind.Core.Crypto;
using Nethermind.Core.Extensions;
using Nethermind.Crypto;
using Nethermind.Crypto.Blake2;

namespace Nethermind.Benchmarks.Evm
{
Expand Down
4 changes: 2 additions & 2 deletions src/Nethermind/Nethermind.Core.Test/Blake2Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

using FluentAssertions;
using Nethermind.Core.Extensions;
using Nethermind.Crypto;
using Nethermind.Crypto.Blake2;
using NUnit.Framework;

namespace Nethermind.Core.Test
Expand All @@ -28,7 +28,7 @@ public class Blake2Tests
[TestCase("0000000c48c9bdf267e6096a3ba7ca8485ae67bb2bf894fe72f36e3cf1361d5f3af54fa5d182e6ad7f520e511f6c3e2b8c68059b6bbd41fbabd9831f79217e1319cde05b61626300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000001", "ba80a53f981c4d0d6a2797b69f12f6e94c212f14685ac4b74b12bb6fdbffa2d17d87c5392aab792dc252d5de4533cc9518d38aa8dbf1925ab92386edd4009923")]
[TestCase("0000000c48c9bdf267e6096a3ba7ca8485ae67bb2bf894fe72f36e3cf1361d5f3af54fa5d182e6ad7f520e511f6c3e2b8c68059b6bbd41fbabd9831f79217e1319cde05b61626300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000000", "75ab69d3190a562c51aef8d88f1c2775876944407270c42c9844252c26d2875298743e7f6d5ea2f2d3e8d226039cd31b4e426ac4f2d3d666a610c2116fde4735")]
[TestCase("0000000148c9bdf267e6096a3ba7ca8485ae67bb2bf894fe72f36e3cf1361d5f3af54fa5d182e6ad7f520e511f6c3e2b8c68059b6bbd41fbabd9831f79217e1319cde05b61626300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000001", "b63a380cb2897d521994a85234ee2c181b5f844d2c624c002677e9703449d2fba551b3a8333bcdf5f2f7e08993d53923de3d64fcc68c034e717b9293fed7a421")]
// [TestCase("ffffffff48c9bdf267e6096a3ba7ca8485ae67bb2bf894fe72f36e3cf1361d5f3af54fa5d182e6ad7f520e511f6c3e2b8c68059b6bbd41fbabd9831f79217e1319cde05b61626300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000001", "fc59093aafa9ab43daae0e914c57635c5402d8e3d2130eb9b3cc181de7f0ecf9b22bf99a7815ce16419e200e01846e6b5df8cc7703041bbceb571de6631d2615")]
[TestCase("ffffffff48c9bdf267e6096a3ba7ca8485ae67bb2bf894fe72f36e3cf1361d5f3af54fa5d182e6ad7f520e511f6c3e2b8c68059b6bbd41fbabd9831f79217e1319cde05b61626300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000001", "fc59093aafa9ab43daae0e914c57635c5402d8e3d2130eb9b3cc181de7f0ecf9b22bf99a7815ce16419e200e01846e6b5df8cc7703041bbceb571de6631d2615")]
public void compression_function_should_return_valid_output(string input, string output)
{
Blake2Compression? blake2Optimized = new();
Expand Down
Loading