-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can_read method for NWBHDF5IO respects NWB version #1703
Conversation
I think this PR just needs tests? |
Yes, I think fixing of errors and adding tests seems to be what's needed. |
Codecov Report
@@ Coverage Diff @@
## dev #1703 +/- ##
==========================================
+ Coverage 83.66% 91.75% +8.08%
==========================================
Files 27 27
Lines 2608 2619 +11
Branches 681 684 +3
==========================================
+ Hits 2182 2403 +221
+ Misses 339 141 -198
+ Partials 87 75 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Motivation
See hdmf-dev/hdmf#875
How to test the behavior?
Checklist
flake8
from the source directory.