Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can_read method for NWBHDF5IO respects NWB version #1703

Merged
merged 8 commits into from
Oct 4, 2023
Merged

can_read method for NWBHDF5IO respects NWB version #1703

merged 8 commits into from
Oct 4, 2023

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Jun 19, 2023

Motivation

See hdmf-dev/hdmf#875

How to test the behavior?

from pynwb import NWBHDF5IO

NWBHDF5IO.can_read("my_nwb_file.nwb")

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@bendichter bendichter requested a review from rly June 19, 2023 15:44
@CodyCBakerPhD
Copy link
Collaborator

I think this PR just needs tests?

@oruebel
Copy link
Contributor

oruebel commented Aug 28, 2023

I think this PR just needs tests?

Yes, I think fixing of errors and adding tests seems to be what's needed.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1703 (b1b956f) into dev (734a6c4) will increase coverage by 8.08%.
The diff coverage is 65.00%.

@@            Coverage Diff             @@
##              dev    #1703      +/-   ##
==========================================
+ Coverage   83.66%   91.75%   +8.08%     
==========================================
  Files          27       27              
  Lines        2608     2619      +11     
  Branches      681      684       +3     
==========================================
+ Hits         2182     2403     +221     
+ Misses        339      141     -198     
+ Partials       87       75      -12     
Flag Coverage Δ
integration 71.09% <65.00%> (?)
unit 83.46% <45.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pynwb/__init__.py 75.73% <65.00%> (+2.95%) ⬆️

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly merged commit 2aceed0 into dev Oct 4, 2023
@rly rly deleted the can_read branch October 4, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants