-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for using the family file driver with PyNWB #1949
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1949 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 27 27
Lines 2656 2656
Branches 693 693
=======================================
Hits 2449 2449
Misses 134 134
Partials 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Thank you very much for putting this together! I think any realistic scenario where the user has on disk file size constraints would probably also have in-memory constraints, so it's probably rare that they'd have their entire dataset in memory. I think the provided example would be more practical and more illustrative if the However, I recognize that this might complicate the message so perhaps it would be enough to just write as much in words.
This glosses over the fact that some of these operations would be done in a different order in an iterative writing scenario but I think that's OK as long as the Iterative Writing documentation is instructive enough. |
@cboulay I updated the example to include this and then also write data iteratively to that dataset. Can you please take a look and see if that addresses your comment. |
There are just a couple small grammar errors noted by me and Ben but otherwise I'd say it's super clear and exactly what I was looking for. Thanks @oruebel! |
Co-authored-by: Ben Dichter <[email protected]>
@stephprince Other than the issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and read clearly! I added some small formatting suggestions, mainly some code references that were italicized that I think were meant to be code blocks. If the italics were intentional you can just ignore those suggestions.
It looks like some of the ruff linter settings were deprecated - I will address those in a separate PR and we can ignore it here for now.
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
Thanks for the suggestions. All those edits looked good and I committed them to this PR. |
Sounds good. I think this PR is then ready to be merged. |
Motivation
Fix #1948
Add docs for using the family file driver with PyNWB
Checklist
ruff check . && codespell
from the source directory.